From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54178) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V1ZH1-0004Ip-QX for qemu-devel@nongnu.org; Tue, 23 Jul 2013 05:52:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V1ZGz-0007uz-G5 for qemu-devel@nongnu.org; Tue, 23 Jul 2013 05:52:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:6505) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V1ZGz-0007ut-8K for qemu-devel@nongnu.org; Tue, 23 Jul 2013 05:52:49 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r6N9qmA3027217 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 23 Jul 2013 05:52:48 -0400 Date: Tue, 23 Jul 2013 11:52:46 +0200 From: Stefan Hajnoczi Message-ID: <20130723095246.GF20256@stefanha-thinkpad.redhat.com> References: <1374054136-28741-1-git-send-email-famz@redhat.com> <1374054136-28741-8-git-send-email-famz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1374054136-28741-8-git-send-email-famz@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 07/11] block: hold hard reference for backup/mirror target List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: kwolf@redhat.com, hbrock@redhat.com, qemu-devel@nongnu.org, rjones@redhat.com, imain@redhat.com, pbonzini@redhat.com On Wed, Jul 17, 2013 at 05:42:12PM +0800, Fam Zheng wrote: > Signed-off-by: Fam Zheng > --- > block/backup.c | 3 ++- > block/mirror.c | 4 ++-- > 2 files changed, 4 insertions(+), 3 deletions(-) Should we update the blockjob.c in_use code instead of adding refcounting to specific block jobs? This ought to be handled generically for all block jobs.