From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55588)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1V1ZMc-0005dd-3G
	for qemu-devel@nongnu.org; Tue, 23 Jul 2013 05:58:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1V1ZMZ-0001HL-KY
	for qemu-devel@nongnu.org; Tue, 23 Jul 2013 05:58:38 -0400
Received: from mx1.redhat.com ([209.132.183.28]:16191)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1V1ZMZ-0001HC-Cl
	for qemu-devel@nongnu.org; Tue, 23 Jul 2013 05:58:35 -0400
Date: Tue, 23 Jul 2013 12:59:54 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20130723095954.GA23217@redhat.com>
References: <1374415744-6675-1-git-send-email-afaerber@suse.de>
	<1374415744-6675-5-git-send-email-afaerber@suse.de>
	<20130721202607.GA15187@redhat.com> <87y58y49tx.fsf@codemonkey.ws>
	<51ED9E71.3060809@suse.de> <20130723070755.GB11106@redhat.com>
	<51EE4895.4010207@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <51EE4895.4010207@suse.de>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH RFC qom-next 4/4] pcie_port: Turn PCIEPort
 and PCIESlot into abstract QOM types
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andreas =?iso-8859-1?Q?F=E4rber?= <afaerber@suse.de>
Cc: qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>, Juan Quintela <quintela@redhat.com>

On Tue, Jul 23, 2013 at 11:10:45AM +0200, Andreas F=E4rber wrote:
> Am 23.07.2013 09:07, schrieb Michael S. Tsirkin:
> > On Mon, Jul 22, 2013 at 11:04:49PM +0200, Andreas F=E4rber wrote:
> >> For VMState I believe the real follow-up fix would be mst defining a
> >> central macro VMSTATE_PCI_DEVICE_AER_LOG() operating on PCIDevice.
> >> Why is that separate from VMSTATE_PCI_DEVICE() or VMSTATE_PCIE_DEVIC=
E()
> >> in the first place?
> >=20
> > The real fix is savevm/loadvm taking into account
> > the class hierarchy.
>=20
> That's not helping, unless you write a patch to show what you mean and

I merely mean that if I inherit a class I should
inherit it's vmstate.
So explicitly adding VMSTATE_PCI_DEVICE should not be
necessary.

> how that is going to be migration-compatible.

Most devices put VMSTATE_PCI_DEVICE at the beninning,
so just calling that before vmstate for the device
should be compatible.

> Does your not answering the question mean you don't know?
>=20
> Andreas

I think the answer is that most pcie devices
don't implement AER. AFAIK PCI devices can't
support AER at all.

> --=20
> SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
> GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrn=
berg