qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gabriel Kerneis <gabriel@kerneis.info>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
	Charlie Shepherd <charlie@ctshepherd.com>,
	qemu-devel@nongnu.org, pbonzini@redhat.com
Subject: Re: [Qemu-devel] RFC [PATCH] Make bdrv_flush synchronous only and update callers
Date: Tue, 23 Jul 2013 13:10:35 +0100	[thread overview]
Message-ID: <20130723121035.GA5330@kerneis.info> (raw)
In-Reply-To: <20130723120515.GA20857@stefanha-thinkpad.redhat.com>

On Tue, Jul 23, 2013 at 02:05:15PM +0200, Stefan Hajnoczi wrote:
> A built-time check for coroutine_fn would be valuable if we ever hope to
> get disciplined with this annotation.
> 
> The check can detect when a coroutine_fn is invoked outside coroutine
> context.  I wonder if Coccinelle can detect this, although I never
> figured out how to use it as a grep-like tool instead of just a
> patch-like tool.

The recent "cps-inference" branch of CPC enables precisely that kind of check.
Charlie is using it to drive his modifications to QEMU and has already suggested
several improvements that I have implemented.  Hopefully we should reach
something fully covering QEMU by the end his GSoC.

If there is interest, I can post a script showing how to build it and use it to
check QEMU annotations (it does not require any modifications to QEMU, only a
couple of configure switches).

Best regards,
-- 
Gabriel

  reply	other threads:[~2013-07-23 12:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-18 21:21 [Qemu-devel] RFC [PATCH] Make bdrv_flush synchronous only and update callers Charlie Shepherd
2013-07-19  5:27 ` Stefan Hajnoczi
2013-07-19  8:37   ` Kevin Wolf
2013-07-23 12:05     ` Stefan Hajnoczi
2013-07-23 12:10       ` Gabriel Kerneis [this message]
2013-07-23 13:36         ` Stefan Hajnoczi
2013-07-23 14:00           ` Gabriel Kerneis
2013-07-25  3:47 ` Wenchao Xia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130723121035.GA5330@kerneis.info \
    --to=gabriel@kerneis.info \
    --cc=charlie@ctshepherd.com \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).