From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44502)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1V1bnQ-0007L4-1L
	for qemu-devel@nongnu.org; Tue, 23 Jul 2013 08:34:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1V1bnN-00057J-5t
	for qemu-devel@nongnu.org; Tue, 23 Jul 2013 08:34:27 -0400
Received: from mx1.redhat.com ([209.132.183.28]:61281)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1V1bnM-00057F-UL
	for qemu-devel@nongnu.org; Tue, 23 Jul 2013 08:34:25 -0400
Date: Tue, 23 Jul 2013 15:35:44 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20130723123544.GB24254@redhat.com>
References: <1374415744-6675-1-git-send-email-afaerber@suse.de>
	<1374415744-6675-5-git-send-email-afaerber@suse.de>
	<20130721202607.GA15187@redhat.com> <87y58y49tx.fsf@codemonkey.ws>
	<51ED9E71.3060809@suse.de> <20130723070755.GB11106@redhat.com>
	<51EE4895.4010207@suse.de> <20130723095954.GA23217@redhat.com>
	<51EE593F.4090101@suse.de> <51EE6729.1010403@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <51EE6729.1010403@redhat.com>
Subject: Re: [Qemu-devel] [PATCH RFC qom-next 4/4] pcie_port: Turn PCIEPort
 and PCIESlot into abstract QOM types
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Juan Quintela <quintela@redhat.com>, Andreas =?iso-8859-1?Q?F=E4rber?= <afaerber@suse.de>, Anthony Liguori <anthony@codemonkey.ws>, qemu-devel@nongnu.org

On Tue, Jul 23, 2013 at 01:21:13PM +0200, Gerd Hoffmann wrote:
>   Hi,
> 
> > Okay, so if it's just PCIe, then XHCI is the oddball preventing moving
> > it into VMSTATE_PCIE_DEVICE(). XHCI has VMSTATE_MSIX() in its place,
> > also operating on PCIDevice.
> 
> Given that live migration support for xhci was added post-1.5 so we
> don't have a release with it yet this shouldn't be a blocker in case we
> get this sorted in time for 1.6.
> 
> > Is there a way to detect use of AER or MSIX to place those into
> > subsections of VMSTATE_PCIE_DEVICE()?
> 
> There is msix_enabled() ...

msix_present()

> Dunno about AER.
> 
> cheers,
>   Gerd


Not at the moment but it's not hard to add.

-- 
MST