From: Stefan Hajnoczi <stefanha@gmail.com>
To: "Benoît Canet" <benoit@irqsave.net>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH V2 for-1.6 1/5] block: Repair the throttling code.
Date: Tue, 23 Jul 2013 16:31:13 +0200 [thread overview]
Message-ID: <20130723143113.GA14190@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1374582067-9063-2-git-send-email-benoit@irqsave.net>
On Tue, Jul 23, 2013 at 02:21:03PM +0200, Benoît Canet wrote:
> The throttling code was segfaulting since commit
> 02ffb504485f0920cfc75a0982a602f824a9a4f4 because some qemu_co_queue_next caller
> does not run in a coroutine.
> qemu_co_queue_do_restart assume that the caller is a coroutinne.
> As sugested by Stefan fix this by entering the coroutine directly.
Please mark qemu_co_queue_next() and qemu_co_queue_restart_all()
coroutine_fn. They may only be called from coroutine context.
Also please add assert(qemu_in_coroutine()) to these functions so an
assertion fires when they are used incorrectly.
next prev parent reply other threads:[~2013-07-23 14:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-23 12:21 [Qemu-devel] [PATCH V2 for-1.6 0/5] Leaky bucket throttling and features Benoît Canet
2013-07-23 12:21 ` [Qemu-devel] [PATCH V2 for-1.6 1/5] block: Repair the throttling code Benoît Canet
2013-07-23 14:31 ` Stefan Hajnoczi [this message]
2013-07-23 12:21 ` [Qemu-devel] [PATCH V2 for-1.6 2/5] block: Modify the throttling code to implement the leaky bucket algorithm Benoît Canet
2013-07-23 14:59 ` Stefan Hajnoczi
2013-07-23 15:14 ` Benoît Canet
2013-07-23 15:20 ` Benoît Canet
2013-07-23 12:21 ` [Qemu-devel] [PATCH V2 for-1.6 3/5] block: Add support for throttling burst threshold in QMP and the command line Benoît Canet
2013-07-23 12:21 ` [Qemu-devel] [PATCH V2 for-1.6 4/5] block: Add iops_sector_count to do the iops accounting for a given io size Benoît Canet
2013-07-23 12:21 ` [Qemu-devel] [PATCH V2 for-1.6 5/5] block: Add throttling percentage metrics Benoît Canet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130723143113.GA14190@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=benoit@irqsave.net \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).