From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55620) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V1x6L-0007tA-86 for qemu-devel@nongnu.org; Wed, 24 Jul 2013 07:19:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V1x6K-0003d3-0z for qemu-devel@nongnu.org; Wed, 24 Jul 2013 07:19:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:64901) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V1x6J-0003cw-QI for qemu-devel@nongnu.org; Wed, 24 Jul 2013 07:19:23 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r6OBJM19015110 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 24 Jul 2013 07:19:22 -0400 Date: Wed, 24 Jul 2013 13:19:18 +0200 From: Kevin Wolf Message-ID: <20130724111918.GB3623@dhcp-200-207.str.redhat.com> References: <1374530960-22031-1-git-send-email-imain@redhat.com> <1374530960-22031-3-git-send-email-imain@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1374530960-22031-3-git-send-email-imain@redhat.com> Subject: Re: [Qemu-devel] [PATCH V6 2/3] Add tests for sync modes 'TOP' and 'NONE' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ian Main Cc: famz@redhat.com, qemu-devel@nongnu.org, rjones@redhat.com, stefanha@redhat.com, pbonzini@redhat.com Am 23.07.2013 um 00:09 hat Ian Main geschrieben: > This patch adds tests for sync modes top and none. Also added are tests > for invalid and missing formats. > > Signed-off-by: Ian Main > --- > tests/qemu-iotests/055 | 108 +++++++++++++++++++++++++++++++++++++----- > tests/qemu-iotests/055.out | 4 +- > tests/qemu-iotests/group | 2 +- > tests/qemu-iotests/iotests.py | 5 ++ > 4 files changed, 103 insertions(+), 16 deletions(-) > @@ -127,7 +202,8 @@ class TestSetSpeed(iotests.QMPTestCase): > self.assert_qmp(result, 'return[0]/device', 'drive0') > self.assert_qmp(result, 'return[0]/speed', 0) > > - result = self.vm.qmp('block-job-set-speed', device='drive0', speed=8 * 1024 * 1024) > + result = self.vm.qmp('block-job-set-speed', device='drive0', > + speed=8 * 1024 * 1024) Forgot adding sync? > self.assert_qmp(result, 'return', {}) > > # Ensure the speed we set was accepted > @@ -285,4 +367,4 @@ class TestSingleTransaction(iotests.QMPTestCase): > self.assert_no_active_block_jobs() > > if __name__ == '__main__': > - iotests.main(supported_fmts=['raw', 'qcow2']) > + iotests.main(supported_fmts=['qcow2', 'qed']) Not good. Can we split the test in a part that can be run by raw, and a separate part that uses backing files? Kevin