From: Kevin Wolf <kwolf@redhat.com>
To: Ian Main <imain@redhat.com>
Cc: famz@redhat.com, qemu-devel@nongnu.org, rjones@redhat.com,
stefanha@redhat.com, pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH V6 3/3] Add backing drive while performing backup.
Date: Wed, 24 Jul 2013 13:28:25 +0200 [thread overview]
Message-ID: <20130724112825.GC3623@dhcp-200-207.str.redhat.com> (raw)
In-Reply-To: <1374530960-22031-4-git-send-email-imain@redhat.com>
Am 23.07.2013 um 00:09 hat Ian Main geschrieben:
> This patch adds the original source drive as a backing drive to our target
> image so that the target image will appear complete during backup. This
> is especially useful for SYNC_MODE_NONE as it allows export via NBD to
> have a complete point-in-time snapshot available for export.
>
> Signed-off-by: Ian Main <imain@redhat.com>
This isn't directly usable, right?
Let's complettely leave it out for now, it's incomplete and most likely
wrong, and that's not easy to fix right. I expect that Fam's patches (at
which I have to take a look yet) offer a more complete solution for
this, but I wouldn't consider any change that allows users to access the
backup target for 1.6, because the user can do all sorts of interesting
things with it then, which we probably don't check for in most cases.
Kevin
next prev parent reply other threads:[~2013-07-24 11:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-22 22:09 [Qemu-devel] [PATCH V6 0/3] Implement sync modes for drive-backup Ian Main
2013-07-22 22:09 ` [Qemu-devel] [PATCH V6 1/3] " Ian Main
2013-07-24 10:55 ` Kevin Wolf
2013-07-24 17:57 ` Ian Main
2013-07-24 20:32 ` Eric Blake
2013-07-24 22:01 ` Ian Main
2013-07-25 11:23 ` Kevin Wolf
2013-07-25 14:36 ` Paolo Bonzini
2013-07-25 16:57 ` Eric Blake
2013-07-25 16:59 ` Paolo Bonzini
2013-07-22 22:09 ` [Qemu-devel] [PATCH V6 2/3] Add tests for sync modes 'TOP' and 'NONE' Ian Main
2013-07-24 11:19 ` Kevin Wolf
2013-07-24 18:02 ` Ian Main
2013-07-22 22:09 ` [Qemu-devel] [PATCH V6 3/3] Add backing drive while performing backup Ian Main
2013-07-24 11:28 ` Kevin Wolf [this message]
2013-07-23 11:53 ` [Qemu-devel] [PATCH V6 0/3] Implement sync modes for drive-backup Stefan Hajnoczi
2013-07-23 19:55 ` Ian Main
2013-07-24 0:55 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130724112825.GC3623@dhcp-200-207.str.redhat.com \
--to=kwolf@redhat.com \
--cc=famz@redhat.com \
--cc=imain@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rjones@redhat.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).