From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56829) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V1xF8-0000lt-90 for qemu-devel@nongnu.org; Wed, 24 Jul 2013 07:28:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V1xF7-0006bD-HS for qemu-devel@nongnu.org; Wed, 24 Jul 2013 07:28:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:15252) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V1xF7-0006b8-A7 for qemu-devel@nongnu.org; Wed, 24 Jul 2013 07:28:29 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r6OBSS2x029489 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 24 Jul 2013 07:28:28 -0400 Date: Wed, 24 Jul 2013 13:28:25 +0200 From: Kevin Wolf Message-ID: <20130724112825.GC3623@dhcp-200-207.str.redhat.com> References: <1374530960-22031-1-git-send-email-imain@redhat.com> <1374530960-22031-4-git-send-email-imain@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1374530960-22031-4-git-send-email-imain@redhat.com> Subject: Re: [Qemu-devel] [PATCH V6 3/3] Add backing drive while performing backup. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ian Main Cc: famz@redhat.com, qemu-devel@nongnu.org, rjones@redhat.com, stefanha@redhat.com, pbonzini@redhat.com Am 23.07.2013 um 00:09 hat Ian Main geschrieben: > This patch adds the original source drive as a backing drive to our target > image so that the target image will appear complete during backup. This > is especially useful for SYNC_MODE_NONE as it allows export via NBD to > have a complete point-in-time snapshot available for export. > > Signed-off-by: Ian Main This isn't directly usable, right? Let's complettely leave it out for now, it's incomplete and most likely wrong, and that's not easy to fix right. I expect that Fam's patches (at which I have to take a look yet) offer a more complete solution for this, but I wouldn't consider any change that allows users to access the backup target for 1.6, because the user can do all sorts of interesting things with it then, which we probably don't check for in most cases. Kevin