From: "Michael S. Tsirkin" <mst@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Anthony Liguori" <aliguori@us.ibm.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
qemu-devel@nongnu.org, "Isaku Yamahata" <yamahata@valinux.co.jp>,
"Alex Williamson" <alex.williamson@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Laszlo Ersek" <lersek@redhat.com>,
"Andreas Färber" <afaerber@suse.de>,
"David Gibson" <david@gibson.dropbear.id.au>
Subject: Re: [Qemu-devel] [PATCH] pc: limit 64 bit hole to 2G by default
Date: Wed, 24 Jul 2013 16:14:11 +0300 [thread overview]
Message-ID: <20130724131411.GB29428@redhat.com> (raw)
In-Reply-To: <51EFCFA6.2050506@redhat.com>
On Wed, Jul 24, 2013 at 02:59:18PM +0200, Paolo Bonzini wrote:
> Il 24/07/2013 11:51, Michael S. Tsirkin ha scritto:
> > > Current seabios uses a slightly different approach: the 64bit hole is
> > > present only in case it is actually used to map bars there, and seabios
> > > tries to fit everything into the 32bit hole first.
> >
> > Yes. But this doesn't work with device hotplug.
>
> Are you preserving that behavior for older machine types?
Older machine types (1.5 and back) don't report PCI hole size to guests
so there's nothing to preserve.
This means there's not much I can do for pc-1.5: as before this
patch, hotplug of devices with large BARs won't work,
and some windows guests will crash if a device with a huge
BAR is added statically.
> (Also, what happens if you do -global i440FX-pcihost.pci_hole64_size=0?
> Does that return a _CRS with only the 32-bit hole)?
>
> Paolo
Yes.
next prev parent reply other threads:[~2013-07-24 13:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-24 6:01 [Qemu-devel] [PATCH] pc: limit 64 bit hole to 2G by default Michael S. Tsirkin
2013-07-24 6:50 ` Andreas Färber
2013-07-24 7:01 ` Gerd Hoffmann
2013-07-24 9:51 ` Michael S. Tsirkin
2013-07-24 10:08 ` Igor Mammedov
2013-07-24 12:59 ` Paolo Bonzini
2013-07-24 13:14 ` Michael S. Tsirkin [this message]
2013-07-24 13:18 ` Paolo Bonzini
2013-07-24 14:07 ` Michael S. Tsirkin
2013-07-24 13:00 ` Gerd Hoffmann
2013-07-25 13:40 ` Igor Mammedov
2013-07-25 15:03 ` Michael S. Tsirkin
2013-07-25 15:16 ` Igor Mammedov
2013-07-25 15:23 ` Michael S. Tsirkin
2013-07-25 15:30 ` Igor Mammedov
2013-07-25 15:35 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130724131411.GB29428@redhat.com \
--to=mst@redhat.com \
--cc=afaerber@suse.de \
--cc=alex.williamson@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=david@gibson.dropbear.id.au \
--cc=ehabkost@redhat.com \
--cc=kraxel@redhat.com \
--cc=lersek@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yamahata@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).