From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35872) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V2GSV-0001fe-Jm for qemu-devel@nongnu.org; Thu, 25 Jul 2013 03:59:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V2GSU-0003Lu-Qh for qemu-devel@nongnu.org; Thu, 25 Jul 2013 03:59:35 -0400 Received: from mail-ea0-x235.google.com ([2a00:1450:4013:c01::235]:56116) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V2GSU-0003Li-KZ for qemu-devel@nongnu.org; Thu, 25 Jul 2013 03:59:34 -0400 Received: by mail-ea0-f181.google.com with SMTP id a15so749787eae.12 for ; Thu, 25 Jul 2013 00:59:33 -0700 (PDT) Date: Thu, 25 Jul 2013 09:59:31 +0200 From: Stefan Hajnoczi Message-ID: <20130725075931.GC19151@stefanha-thinkpad.redhat.com> References: <1374054136-28741-1-git-send-email-famz@redhat.com> <1374054136-28741-8-git-send-email-famz@redhat.com> <20130723095246.GF20256@stefanha-thinkpad.redhat.com> <20130725060842.GA9893@T430s.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130725060842.GA9893@T430s.redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 07/11] block: hold hard reference for backup/mirror target List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: kwolf@redhat.com, hbrock@redhat.com, qemu-devel@nongnu.org, rjones@redhat.com, imain@redhat.com, Stefan Hajnoczi , pbonzini@redhat.com On Thu, Jul 25, 2013 at 02:08:42PM +0800, Fam Zheng wrote: > On Tue, 07/23 11:52, Stefan Hajnoczi wrote: > > On Wed, Jul 17, 2013 at 05:42:12PM +0800, Fam Zheng wrote: > > > Signed-off-by: Fam Zheng > > > --- > > > block/backup.c | 3 ++- > > > block/mirror.c | 4 ++-- > > > 2 files changed, 4 insertions(+), 3 deletions(-) > > > > Should we update the blockjob.c in_use code instead of adding > > refcounting to specific block jobs? This ought to be handled > > generically for all block jobs. > > Target is not common in block jobs (e.g. doesn't apply to block-commit), > so it seems only specific block job knows about this. Of course you are right. Stefan