From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55236) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V2HRK-0007Ly-Tp for qemu-devel@nongnu.org; Thu, 25 Jul 2013 05:02:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V2HRG-0000n8-3h for qemu-devel@nongnu.org; Thu, 25 Jul 2013 05:02:26 -0400 Received: from mail-ee0-x235.google.com ([2a00:1450:4013:c00::235]:38295) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V2HRF-0000mq-Sg for qemu-devel@nongnu.org; Thu, 25 Jul 2013 05:02:22 -0400 Received: by mail-ee0-f53.google.com with SMTP id e53so775620eek.40 for ; Thu, 25 Jul 2013 02:02:21 -0700 (PDT) Date: Thu, 25 Jul 2013 11:02:18 +0200 From: Stefan Hajnoczi Message-ID: <20130725090218.GB21033@stefanha-thinkpad.redhat.com> References: <51E8E204.8000201@redhat.com> <1374254783-8077-1-git-send-email-alex@alex.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1374254783-8077-1-git-send-email-alex@alex.org.uk> Subject: Re: [Qemu-devel] [PATCH] [RFC] aio/timers: Drop alarm timers; introduce QEMUClock to AioContext; run timers in aio_poll List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex Bligh Cc: Kevin Wolf , Anthony Liguori , qemu-devel@nongnu.org, Stefan Hajnoczi , Paolo Bonzini , rth@twiddle.net On Fri, Jul 19, 2013 at 06:26:23PM +0100, Alex Bligh wrote: > [ This is a patch for RFC purposes only. It is compile tested on Linux x86_64 only > and passes make check (or rather did before make check started dying in the > boot order test - different bug). I'd like to know whether I'm going in > the right direction ] > > We no longer need alarm timers to trigger QEMUTimer as we'll be polling > them in aio_poll. > > Remove static declaration from qemu_new_clock and introduce qemu_free_clock. > > Maintain a list of QEMUClocks. > > Introduce qemu_clock_deadline_ns and qemu_clock_deadine_all_ns which calculate how > long aio_poll etc. should wait, plus (for the time being) a conversion to milliseconds. > > Make qemu_run_timers return a bool to indicate progress. > > Add QEMUClock to AioContext. > > Run timers attached to clock in aio_poll > > Signed-off-by: Alex Bligh > --- > aio-posix.c | 16 +- > aio-win32.c | 20 +- > async.c | 2 + > include/block/aio.h | 5 + > include/qemu/timer.h | 15 +- > main-loop.c | 9 +- > qemu-timer.c | 599 ++++++++------------------------------------------ > vl.c | 5 +- > 8 files changed, 150 insertions(+), 521 deletions(-) I think you've already split this into a series. Will review that, just catching up on your emails :). Stefan