From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43480)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1V2Jbv-0000u4-B6
	for qemu-devel@nongnu.org; Thu, 25 Jul 2013 07:21:35 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1V2Jbs-0001Y1-Jh
	for qemu-devel@nongnu.org; Thu, 25 Jul 2013 07:21:31 -0400
Received: from mx1.redhat.com ([209.132.183.28]:39646)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1V2Jbs-0001Xt-Bl
	for qemu-devel@nongnu.org; Thu, 25 Jul 2013 07:21:28 -0400
Received: from int-mx10.intmail.prod.int.phx2.redhat.com
	(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r6PBLQbe010891
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Thu, 25 Jul 2013 07:21:27 -0400
Date: Thu, 25 Jul 2013 14:22:47 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20130725112247.GA28893@redhat.com>
References: <1374681580-17439-1-git-send-email-mst@redhat.com>
	<1374681580-17439-13-git-send-email-mst@redhat.com>
	<51F0FE20.7050302@redhat.com> <20130725105526.GA28819@redhat.com>
	<51F10668.5020100@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <51F10668.5020100@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 12/14] pvpanic: add API to access io port
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org

On Thu, Jul 25, 2013 at 01:05:12PM +0200, Gerd Hoffmann wrote:
>   Hi,
> 
> > I can change the implementation but I don't think it's
> > a good idea to copy property names around:
> > it's too fragile, compiler won't warn us if we
> > change the name or value semantics,
> 
> I'm not worried.  Changing the strings will break the command line
> interface too (qemu -device pvpanic,ioport=...), so that isn't going to
> happen.
> 
> cheers,
>   Gerd

What will catch this breakage?
There are 0 users actually tweaking the port
number so I'm sure no one will notice this.

In any case, catching errors at compile time
is much better than at runtime.

What exactly are advantages of duplicating
property names in this way? I don't see any.

-- 
MST