From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54796) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V2KLR-0001Xn-R2 for qemu-devel@nongnu.org; Thu, 25 Jul 2013 08:08:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V2KLO-0001A9-Mw for qemu-devel@nongnu.org; Thu, 25 Jul 2013 08:08:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46916) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V2KLO-0001A3-GY for qemu-devel@nongnu.org; Thu, 25 Jul 2013 08:08:30 -0400 Date: Thu, 25 Jul 2013 20:08:22 +0800 From: Fam Zheng Message-ID: <20130725120822.GA14010@T430s.redhat.com> References: <1374596968-20181-1-git-send-email-benoit@irqsave.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <1374596968-20181-1-git-send-email-benoit@irqsave.net> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH V3 for-1.6 0/5] Leaky bucket throttling and features Reply-To: famz@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?iso-8859-1?Q?Beno=EEt?= Canet Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com On Tue, 07/23 18:29, Beno=EEt Canet wrote: > The first patch fixes the throttling which was broken by a previous com= mit. >=20 > The next patch replace the existing throttling algorithm by the well de= scribed > leaky bucket algorithm. >=20 > Third patch implement bursting by adding *_threshold parameters to > qmp_block_set_io_throttle. >=20 > The last one allow to define the max size of an io when throttling by i= ops via > iops_sector_count to avoid vm users cheating on the iops limit. >=20 > The last patch adds a metric reflecting how much the I/O are throttled. >=20 My ignorant question: Besides the fix, how is io throttling improved from previously, what are the advantages of leaky bucket algorithm? Thanks. Fam