From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48875) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V2LUG-0005p0-BN for qemu-devel@nongnu.org; Thu, 25 Jul 2013 09:21:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V2LUD-0002iK-Hq for qemu-devel@nongnu.org; Thu, 25 Jul 2013 09:21:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35231) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V2LUD-0002iE-AB for qemu-devel@nongnu.org; Thu, 25 Jul 2013 09:21:41 -0400 Date: Thu, 25 Jul 2013 16:23:01 +0300 From: "Michael S. Tsirkin" Message-ID: <20130725132301.GA2575@redhat.com> References: <1374681580-17439-1-git-send-email-mst@redhat.com> <1374681580-17439-15-git-send-email-mst@redhat.com> <51F122D1.4010600@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <51F122D1.4010600@redhat.com> Subject: Re: [Qemu-devel] [PATCH v3 14/14] i386: ACPI table generation code from seabios List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: Anthony Liguori , qemu-devel@nongnu.org On Thu, Jul 25, 2013 at 03:06:25PM +0200, Gerd Hoffmann wrote: > Hi, > > > As table content is likely to change over time, > > the following measures are taken to simplify > > cross-version migration: > > - All tables besides the RSDP are packed in a single FW CFG entry. > > This entry size is currently 23K. We round it up to 64K > > to avoid too much churn there. > > Does it need to be that way? I'd prefer to have one fw_cfg entry per table. > > cheers, > Gerd > It's better I think. The advantages are: - when we add more tables we don't break cross-version migration compatibility - we have limited number of files, this way we won't run out of them what are advantages of file per table?