From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43832)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1V2Mse-0002GK-Ss
	for qemu-devel@nongnu.org; Thu, 25 Jul 2013 10:51:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1V2Msb-0000wY-Ba
	for qemu-devel@nongnu.org; Thu, 25 Jul 2013 10:51:00 -0400
Received: from mx1.redhat.com ([209.132.183.28]:28318)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1V2Msa-0000wO-QK
	for qemu-devel@nongnu.org; Thu, 25 Jul 2013 10:50:57 -0400
Date: Thu, 25 Jul 2013 17:52:15 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20130725145215.GA3758@redhat.com>
References: <87li4v8ktz.fsf@rustcorp.com.au>
	<CA+aC4ksBr62tX1aiAXnVueixgyvgFu5uq17TEiD8sZRKD_Tp3w@mail.gmail.com>
	<87ehan8hhn.fsf@rustcorp.com.au> <87ppu66a73.fsf@codemonkey.ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87ppu66a73.fsf@codemonkey.ws>
Subject: Re: [Qemu-devel] vhost acceleration broken?
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Rusty Russell <rusty@rustcorp.com.au>, qemu-devel <qemu-devel@nongnu.org>, Stefan Hajnoczi <stefanha@redhat.com>

On Thu, Jul 25, 2013 at 08:28:00AM -0500, Anthony Liguori wrote:
> Rusty Russell <rusty@rustcorp.com.au> writes:
> 
> > Anthony Liguori <anthony@codemonkey.ws> writes:
> >> On Wed, Jul 24, 2013 at 8:55 PM, Rusty Russell <rusty@rustcorp.com.au> wrote:
> >>> Hi all,
> >>>
> >>>         Using latest kernel and master qemu, the following doesn't use
> >>> vhost acceleration:
> >>>
> >>> sudo qemu-system-x86_64 -machine pc,accel=kvm $ARGS -m 1024 -net tap,script=/home/rusty/bin/kvm-ifup,downscript=no,vhost=on -net nic,model=virtio -drive file=$QEMUIMAGE,index=0,media=disk,if=virtio -kernel arch/x86/boot/bzImage -append "root=/dev/vda1 $KARGS $*"
> >>
> >> sudo qemu-system-x86_64 -enable-kvm $ARGS -m 1G -netdev
> >> tap,script=/home/rusty/bin/kvm-ifup,vhost=on,id=net0 -device
> >> virtio-net-pci,netdev=net0 -drive file=$QEMUIMAGE,if=virtio -kernel
> >> arch/x86/boot/bzImage -append "root=/dev/vda1 $KARGS $*"
> >>
> >> We really ought to strongly deprecate -net because it's misleading.  I
> >> suspect we can reasonably add a warning for model=virtio saying
> >> "please don't use this" and eventually remove it entirely.
> >
> > Thankyou, that works.
> >
> > I'm sure you've thought more deeply about the qemu cmdline than I have,
> > so I won't comment.
> 
> Any comment you would make is certainly fair.
> 
> We have a pretty awful legacy command line set that comes from years of
> half-baked concepts and the years when too many people just committed
> random shit to the tree.
> 
> I think we probably need to start planning for a clean break.  Maybe
> that's a good target for a 2.0 version...
> 
> Regards,
> 
> Anthony Liguori
> 
> >
> > Cheers,
> > Rusty.

Assuming -netdev supports all required configurations, we should
remove -net from the -help output.