From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37164) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V2P9k-0003OB-Vg for qemu-devel@nongnu.org; Thu, 25 Jul 2013 13:16:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V2P9i-0007rm-ID for qemu-devel@nongnu.org; Thu, 25 Jul 2013 13:16:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:9866) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V2P9i-0007rS-AD for qemu-devel@nongnu.org; Thu, 25 Jul 2013 13:16:46 -0400 Date: Thu, 25 Jul 2013 20:18:05 +0300 From: "Michael S. Tsirkin" Message-ID: <20130725171805.GA7875@redhat.com> References: <1374681580-17439-1-git-send-email-mst@redhat.com> <51F1495F.2010502@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <51F1495F.2010502@suse.de> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v3 00/14] qemu: generate acpi tables for the guest List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?iso-8859-1?Q?F=E4rber?= Cc: qemu-devel@nongnu.org, Anthony Liguori On Thu, Jul 25, 2013 at 05:50:55PM +0200, Andreas F=E4rber wrote: > Am 24.07.2013 18:01, schrieb Michael S. Tsirkin: > > This code can also be found here: > > git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git acpi > >=20 > > Please review, and consider for 1.6. >=20 > Quite frankly, this is still not looking the way I imagined it based on > the KVM call discussion and Anthony's comments that I remember: By the way, for examples which are exactly like this code here, look no further than: FWCfgState *fw_cfg_find(void); and the use in hw/misc/pvpanic.c of said API. Here we have device implementing an API to find it, and through this pointer, it is accessed by more APIs access its state. This is exactly what my patches do for piix etc. So if you don't like this approach, please change existing code using it. --=20 MST