From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34449)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1V2d7j-0000PN-DQ
	for qemu-devel@nongnu.org; Fri, 26 Jul 2013 04:11:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1V2d7i-00018a-Ad
	for qemu-devel@nongnu.org; Fri, 26 Jul 2013 04:11:39 -0400
Received: from mail-ee0-x229.google.com ([2a00:1450:4013:c00::229]:60679)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1V2d7i-00018T-46
	for qemu-devel@nongnu.org; Fri, 26 Jul 2013 04:11:38 -0400
Received: by mail-ee0-f41.google.com with SMTP id d17so903126eek.0
	for <qemu-devel@nongnu.org>; Fri, 26 Jul 2013 01:11:37 -0700 (PDT)
Date: Fri, 26 Jul 2013 10:11:34 +0200
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20130726081134.GA31438@stefanha-thinkpad.redhat.com>
References: <1374069835-14287-1-git-send-email-xiawenc@linux.vnet.ibm.com>
	<1374069835-14287-4-git-send-email-xiawenc@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1374069835-14287-4-git-send-email-xiawenc@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH 3/4] qemu-nbd: add doc for internal
 snapshot export
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, dietmar@proxmox.com

On Wed, Jul 17, 2013 at 10:03:54PM +0800, Wenchao Xia wrote:
> Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
> ---
>  qemu-nbd.c    |    2 ++
>  qemu-nbd.texi |    3 +++
>  2 files changed, 5 insertions(+), 0 deletions(-)
> 
> diff --git a/qemu-nbd.c b/qemu-nbd.c
> index 46be2b2..8eeee33 100644
> --- a/qemu-nbd.c
> +++ b/qemu-nbd.c
> @@ -80,6 +80,8 @@ static void usage(const char *name)
>  "Block device options:\n"
>  "  -r, --read-only      export read-only\n"
>  "  -s, --snapshot       use snapshot file\n"
> +"  -l, --snapshot-load  temporarily load an internal snapshot and export it as\n"
> +"                       an read-only device, format is 'id=[ID],name=[NAME]'\n"

Does it really export it read-only?  I think you'll get an error unless
you pass qemu-nbd --read-only.