From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36990)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1V2dGn-0003ad-QM
	for qemu-devel@nongnu.org; Fri, 26 Jul 2013 04:21:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1V2dGm-0004kc-Rs
	for qemu-devel@nongnu.org; Fri, 26 Jul 2013 04:21:01 -0400
Received: from mail-ea0-x22a.google.com ([2a00:1450:4013:c01::22a]:40372)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1V2dGm-0004kY-LW
	for qemu-devel@nongnu.org; Fri, 26 Jul 2013 04:21:00 -0400
Received: by mail-ea0-f170.google.com with SMTP id h10so1448910eaj.1
	for <qemu-devel@nongnu.org>; Fri, 26 Jul 2013 01:21:00 -0700 (PDT)
Date: Fri, 26 Jul 2013 10:20:57 +0200
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20130726082057.GB31438@stefanha-thinkpad.redhat.com>
References: <1374069835-14287-1-git-send-email-xiawenc@linux.vnet.ibm.com>
	<51F08DD9.8010301@linux.vnet.ibm.com>
	<20130725080630.GD19151@stefanha-thinkpad.redhat.com>
	<51F1DD9C.9090405@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <51F1DD9C.9090405@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH 0/4] export internal snapshot by qemu-nbd
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, dietmar@proxmox.com

On Fri, Jul 26, 2013 at 10:23:24AM +0800, Wenchao Xia wrote:
> 于 2013-7-25 16:06, Stefan Hajnoczi 写道:
> >On Thu, Jul 25, 2013 at 10:30:49AM +0800, Wenchao Xia wrote:
> >>   Besides the argument, I think it helps to probe snapshot without
> >>qemu-img convert, hope to get comments for the code.
> >
> >Hi Wenchao,
> >Which patch are you referring to?
> >
> >Stefan
> >
>   This series, which enable qemu-nbd load a snapshot. It is quite
> simple, look forward to your opinion, especially the parameter of
> qemu-nbd part in patch 2.

I understand now.  Adding bdrv_snapshot_load_tmp() support to qemu-nbd
is useful, it's a shame that the --snapshot/-s option is already taken
and likely to cause confusion.  The documentation needs to be very clear
that --snapshot and --snapshot-load refer to different snapshot
concepts.

Stefan