From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40500)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1V2dTr-0000CX-Lt
	for qemu-devel@nongnu.org; Fri, 26 Jul 2013 04:34:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1V2dTo-0000y5-Mm
	for qemu-devel@nongnu.org; Fri, 26 Jul 2013 04:34:31 -0400
Received: from mail-ee0-x230.google.com ([2a00:1450:4013:c00::230]:61522)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1V2dTo-0000xw-Gg
	for qemu-devel@nongnu.org; Fri, 26 Jul 2013 04:34:28 -0400
Received: by mail-ee0-f48.google.com with SMTP id b47so1396530eek.7
	for <qemu-devel@nongnu.org>; Fri, 26 Jul 2013 01:34:27 -0700 (PDT)
Date: Fri, 26 Jul 2013 10:34:25 +0200
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20130726083425.GD31438@stefanha-thinkpad.redhat.com>
References: <1E8E204.8000201@redhat.com>
	<1374343603-29183-1-git-send-email-alex@alex.org.uk>
	<1374343603-29183-7-git-send-email-alex@alex.org.uk>
	<20130725093343.GF21033@stefanha-thinkpad.redhat.com>
	<3379099F707F8EF4EA235B6B@nimrod.local>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <3379099F707F8EF4EA235B6B@nimrod.local>
Subject: Re: [Qemu-devel] [PATCHv2] [RFC 6/7] aio / timers: Switch to ppoll,
 run AioContext timers in aio_poll/aio_dispatch
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alex Bligh <alex@alex.org.uk>
Cc: Kevin Wolf <kwolf@redhat.com>, Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, rth@twiddle.net

On Thu, Jul 25, 2013 at 03:53:55PM +0100, Alex Bligh wrote:
> Stefan,
> 
> --On 25 July 2013 11:33:43 +0200 Stefan Hajnoczi <stefanha@gmail.com> wrote:
> 
> >>     assert(progress || busy);
> >>-    return true;
> >>+    return progress;
> >
> >Now aio_poll() can return false when it used to return true?
> 
> I don't think that's a bug.
> 
> Firstly, this is the same thing you fixed and we discussed on another
> thread.

I'm fine with the change itself but it needs to be explained in the
commit message or a comment.

In the patch where I changed the semantics of aio_poll() the change is
explained in detail in the commit message:

http://patchwork.ozlabs.org/patch/261786/

Stefan