From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47994) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V2l0n-0008Fb-9l for qemu-devel@nongnu.org; Fri, 26 Jul 2013 12:37:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V2l0i-0002eR-Gj for qemu-devel@nongnu.org; Fri, 26 Jul 2013 12:37:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:16291) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V2l0i-0002eJ-8r for qemu-devel@nongnu.org; Fri, 26 Jul 2013 12:36:56 -0400 Date: Fri, 26 Jul 2013 12:36:43 -0400 From: Jeff Cody Message-ID: <20130726163643.GD19811@localhost.localdomain> References: <1374765505-14356-1-git-send-email-stefanha@redhat.com> <1374765505-14356-7-git-send-email-stefanha@redhat.com> <20130726161001.GA28317@localhost.localdomain> <51F2A2EE.5040403@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <51F2A2EE.5040403@redhat.com> Subject: Re: [Qemu-devel] [PATCH v6 06/18] aio: stop using .io_flush() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Kevin Wolf , Ping Fan Liu , Stefan Hajnoczi , qemu-devel@nongnu.org, Michael Roth , alex@alex.org.uk On Fri, Jul 26, 2013 at 06:25:18PM +0200, Paolo Bonzini wrote: > Il 26/07/2013 18:10, Jeff Cody ha scritto: > > + /* wait until next event that is not aio_notify() */ > > + while (count > 1) { > > > > This would assume of course that aio_notify() is always first in the > > list. > > No, you cannot assume that. Any bdrv can be opened early (with -drive) > and then associated to an AioContext that is created later (when the > dataplane thread start). > > Paolo > OK, good point, thanks. Jeff