From: Ian Main <imain@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: kwolf@redhat.com, famz@redhat.com, qemu-devel@nongnu.org,
stefanha@redhat.com, rjones@redhat.com
Subject: Re: [Qemu-devel] [PATCH V7 1/2] Implement sync modes for drive-backup.
Date: Fri, 26 Jul 2013 10:15:09 -0700 [thread overview]
Message-ID: <20130726171509.GA1605@gate.mains.priv> (raw)
In-Reply-To: <51F21E08.8060109@redhat.com>
On Fri, Jul 26, 2013 at 08:58:16AM +0200, Paolo Bonzini wrote:
> Il 26/07/2013 03:09, Ian Main ha scritto:
> > + /* See if we have a backing HD we can use to create our new image
> > + * on top of. */
> > + source = bs->backing_hd;
> > + if (!source && sync == MIRROR_SYNC_MODE_TOP) {
> > + sync = MIRROR_SYNC_MODE_FULL;
> > + }
> > +
>
> I understand why you left out the "magic" backing file manipulation, but
> source should still be "bs" for MIRROR_SYNC_MODE_NONE.
OK. Eventually I'll get it right :)
Ian
next prev parent reply other threads:[~2013-07-26 17:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-26 1:09 [Qemu-devel] [PATCH V7 0/2] Implement sync modes for drive-backup Ian Main
2013-07-26 1:09 ` [Qemu-devel] [PATCH V7 1/2] " Ian Main
2013-07-26 6:58 ` Paolo Bonzini
2013-07-26 17:15 ` Ian Main [this message]
2013-07-26 1:09 ` [Qemu-devel] [PATCH V7 2/2] Add tests for sync modes 'TOP' and 'NONE' Ian Main
2013-07-26 16:58 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130726171509.GA1605@gate.mains.priv \
--to=imain@redhat.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rjones@redhat.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).