From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57994)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imain@redhat.com>) id 1V2lbr-0007zg-1m
	for qemu-devel@nongnu.org; Fri, 26 Jul 2013 13:15:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <imain@redhat.com>) id 1V2lbm-0007v0-RP
	for qemu-devel@nongnu.org; Fri, 26 Jul 2013 13:15:18 -0400
Received: from mx1.redhat.com ([209.132.183.28]:44794)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imain@redhat.com>) id 1V2lbm-0007uV-KZ
	for qemu-devel@nongnu.org; Fri, 26 Jul 2013 13:15:14 -0400
Received: from int-mx10.intmail.prod.int.phx2.redhat.com
	(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r6QHFCr4024516
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Fri, 26 Jul 2013 13:15:13 -0400
Date: Fri, 26 Jul 2013 10:15:09 -0700
From: Ian Main <imain@redhat.com>
Message-ID: <20130726171509.GA1605@gate.mains.priv>
References: <1374800982-2818-1-git-send-email-imain@redhat.com>
	<1374800982-2818-2-git-send-email-imain@redhat.com>
	<51F21E08.8060109@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <51F21E08.8060109@redhat.com>
Subject: Re: [Qemu-devel] [PATCH V7 1/2] Implement sync modes for
	drive-backup.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: kwolf@redhat.com, famz@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, rjones@redhat.com

On Fri, Jul 26, 2013 at 08:58:16AM +0200, Paolo Bonzini wrote:
> Il 26/07/2013 03:09, Ian Main ha scritto:
> > +    /* See if we have a backing HD we can use to create our new image
> > +     * on top of. */
> > +    source = bs->backing_hd;
> > +    if (!source && sync == MIRROR_SYNC_MODE_TOP) {
> > +        sync = MIRROR_SYNC_MODE_FULL;
> > +    }
> > +
> 
> I understand why you left out the "magic" backing file manipulation, but
> source should still be "bs" for MIRROR_SYNC_MODE_NONE.

OK.  Eventually I'll get it right :)

	Ian