From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38680)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1V2qL8-0005tZ-7X
	for qemu-devel@nongnu.org; Fri, 26 Jul 2013 18:18:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1V2qL6-000770-NY
	for qemu-devel@nongnu.org; Fri, 26 Jul 2013 18:18:22 -0400
Received: from mail-la0-x231.google.com ([2a00:1450:4010:c03::231]:36653)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1V2qL6-00076u-Fn
	for qemu-devel@nongnu.org; Fri, 26 Jul 2013 18:18:20 -0400
Received: by mail-la0-f49.google.com with SMTP id ea20so2684516lab.8
	for <qemu-devel@nongnu.org>; Fri, 26 Jul 2013 15:18:19 -0700 (PDT)
Date: Sat, 27 Jul 2013 00:17:54 +0200
From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Message-ID: <20130726221754.GJ25811@smtp.vpn>
References: <1373408640-6046-1-git-send-email-afaerber@suse.de>
	<CAMo8BfLZooX6UvDBruT9xvZeajoyR=mbPX958M3yMkQbQPnn_A@mail.gmail.com>
	<51F2EAED.3040003@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <51F2EAED.3040003@suse.de>
Subject: Re: [Qemu-devel] [PATCH qom-cpu v3 00/41] QOM CPUState,
 part 11: GDB stub
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andreas =?iso-8859-1?Q?F=E4rber?= <afaerber@suse.de>
Cc: Peter Maydell <peter.maydell@linaro.org>, Anthony Green <green@moxielogic.com>, qemu-devel@nongnu.org, Blue Swirl <blauwirbel@gmail.com>, Max Filippov <jcmvbkbc@gmail.com>, Michael Walle <michael@walle.cc>, Jan Kiszka <jan.kiszka@web.de>, Anthony Liguori <anthony@codemonkey.ws>, Paolo Bonzini <pbonzini@redhat.com>, Guan Xuetao <gxt@mprc.pku.edu.cn>, =?iso-8859-1?Q?Aur=E9lien?= Jarno <aurelien@aurel32.net>, Richard Henderson <rth@twiddle.net>

On Fri, Jul 26, 2013 at 11:32:29PM +0200, Andreas Färber wrote:
> Am 23.07.2013 12:32, schrieb Max Filippov:
> > On Wed, Jul 10, 2013 at 2:23 AM, Andreas Färber <afaerber@suse.de> wrote:
> >> Hello,
> >>
> >> This series cleans up gdbstub by changing all its internal CPU state to CPUState
> >> and by moving most target-specific code into the target directories.
> >>
> >> Support for m68k, moxie and unicore32 to set the PC via gdbstub is added.
> >>
> >> Lightweight subclasses for XtensaCPU are introduced, keeping the XtensaConfig
> >> mechanisms, to stop xtensa from deviating at gdbstub level wrt register count.
> >>
> >> I still wonder whether there would be interest in adding a "program-counter"
> >> dynamic property to the CPU, given that a setter has been factored out here?
> >>
> >> v3 avoids find_cpu() related breakages by deferring GDBState::c_cpu conversion
> >> until GDBState::g_cpu and find_cpu() can easily be converted, too.
> >>
> >> Available for testing at:
> >> git://github.com/afaerber/qemu-cpu.git qom-cpu-11.v3
> >> https://github.com/afaerber/qemu-cpu/commits/qom-cpu-11.v3
> > 
> > xtensa parts: Acked-by: Max Filippov <jcmvbkbc@gmail.com>
> 
> Thanks, applied to qom-cpu:
> https://github.com/afaerber/qemu-cpu/commits/qom-cpu
> 
> Edgar, since I got no feedback on the crisv10 patch but got an ack on
> the equivalent do_interrupt() change, I'm assuming you're okay with
> this. We can still do code cleanups unifying pre-v32 stuff as follow-up.

Yes, these are good changes, thanks!

Cheers,
Edgar