From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45105)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1V3RdK-0006GT-0g
	for qemu-devel@nongnu.org; Sun, 28 Jul 2013 10:07:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1V3RdE-00034n-0T
	for qemu-devel@nongnu.org; Sun, 28 Jul 2013 10:07:37 -0400
Received: from mx1.redhat.com ([209.132.183.28]:3475)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1V3RdD-00034g-PH
	for qemu-devel@nongnu.org; Sun, 28 Jul 2013 10:07:31 -0400
Date: Sun, 28 Jul 2013 17:08:53 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20130728140853.GA22158@redhat.com>
References: <1374975670-8820-1-git-send-email-afaerber@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <1374975670-8820-1-git-send-email-afaerber@suse.de>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH RFC for-1.6 qom-next 0/3] PCIe VMState
	cleanups for 1.6
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andreas =?iso-8859-1?Q?F=E4rber?= <afaerber@suse.de>
Cc: Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>, Juan Quintela <quintela@redhat.com>

On Sun, Jul 28, 2013 at 03:41:07AM +0200, Andreas F=E4rber wrote:
> Hello Michael and Gerd,
>=20
> As discussed, this series attempts to clean up PCIe devices fiddling wi=
th
> individual PCIe VMState fields. It is based on my qom-next queue, conta=
ining
> type and field changes for PCIe devices.
>=20
> Patch 1 assumes the following are equivalent:
> a) - Struct A
>      - Field Aa
>      ...
>    - Field X
>      ...
> b) - Struct A
>      - Field Aa
>      ...
>      - Field X
>=20
> Patch 2 relies on XHCI not being released yet, thus no compatibiliy con=
cerns.
>=20
> Patch 3 assumes the following are equivalent:
> a) - Struct A
>      - Field Aa
>      ...
>      - Field X
> b) - Struct A
>      - Field Aa
>      ...
>      - Subsection Ax
>        - Field X
>=20
> CC'ing Juan to verify which of these are correct/safe.
>=20
> Regards,
> Andreas

As far as I know 2a and 2b are not equivalent: subsections
are serialized in the file.
You really should test by migrating to file (e.g. before
starting the guest) and checking.
Also, migrate to file from before patch and load after patch.