From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35834) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V3TFo-0003K2-Hh for qemu-devel@nongnu.org; Sun, 28 Jul 2013 11:51:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V3TFg-0003D5-9d for qemu-devel@nongnu.org; Sun, 28 Jul 2013 11:51:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:13940) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V3TFg-0003CH-1y for qemu-devel@nongnu.org; Sun, 28 Jul 2013 11:51:20 -0400 Date: Sun, 28 Jul 2013 18:52:40 +0300 From: "Michael S. Tsirkin" Message-ID: <20130728155240.GA7458@redhat.com> References: <1374975670-8820-1-git-send-email-afaerber@suse.de> <20130728140853.GA22158@redhat.com> <51F531C6.8010302@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <51F531C6.8010302@suse.de> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH RFC for-1.6 qom-next 0/3] PCIe VMState cleanups for 1.6 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?iso-8859-1?Q?F=E4rber?= Cc: Gerd Hoffmann , qemu-devel@nongnu.org, Anthony Liguori , Juan Quintela On Sun, Jul 28, 2013 at 04:59:18PM +0200, Andreas F=E4rber wrote: > Am 28.07.2013 16:08, schrieb Michael S. Tsirkin: > > On Sun, Jul 28, 2013 at 03:41:07AM +0200, Andreas F=E4rber wrote: > >> Hello Michael and Gerd, > >> > >> As discussed, this series attempts to clean up PCIe devices fiddling= with > >> individual PCIe VMState fields. It is based on my qom-next queue, co= ntaining > >> type and field changes for PCIe devices. > >> > >> Patch 1 assumes the following are equivalent: > >> a) - Struct A > >> - Field Aa > >> ... > >> - Field X > >> ... > >> b) - Struct A > >> - Field Aa > >> ... > >> - Field X > >> > >> Patch 2 relies on XHCI not being released yet, thus no compatibiliy = concerns. > >> > >> Patch 3 assumes the following are equivalent: > >> a) - Struct A > >> - Field Aa > >> ... > >> - Field X > >> b) - Struct A > >> - Field Aa > >> ... > >> - Subsection Ax > >> - Field X > >> > >> CC'ing Juan to verify which of these are correct/safe. > >=20 > > As far as I know 2a and 2b are not equivalent: subsections > > are serialized in the file. >=20 > I'm guessing you mean scenarios 3a and 3b. Too bad. >=20 > But when we want to unify PCI and PCIe as you suggested elsewhere, > introducing a PCIe-only subsection in patch 2 seems a bad idea. >=20 > In that case we could use VMSTATE_STRUCT_TEST(), I'll look into that. Right. > Using that I think we can postpone this beyond 1.6, since XHCI is not > initializing AER. >=20 > Series formally retracted. >=20 > > You really should test by migrating to file (e.g. before > > starting the guest) and checking. > > Also, migrate to file from before patch and load after patch. >=20 > OK. For virtio and NICs that's trivial and for the ioh there's > docs/q35-chipset.cfg. >=20 > How do I use and test those xio upstream/downstream PCIe devices? >=20 > Andreas >=20 > --=20 > SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany > GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrn= berg