* [Qemu-devel] [PATCH] target-mips: fix multiplication in mipsdsp_rndq15_mul_q15_q15
@ 2013-05-23 17:37 Petar Jovanovic
2013-06-09 2:36 ` Petar Jovanovic
2013-07-28 16:28 ` Aurelien Jarno
0 siblings, 2 replies; 10+ messages in thread
From: Petar Jovanovic @ 2013-05-23 17:37 UTC (permalink / raw)
To: qemu-devel; +Cc: petar.jovanovic, aurelien
From: Petar Jovanovic <petar.jovanovic@imgtec.com>
Multiplication of Q15 fractional halfword vectors was incorrect in the
previous implementation of mipsdsp_rndq15_mul_q15_q15. It failed to take
element signs into account. This change fixes it, and it adds a test case
for it.
The change also removes unnecessary cast in the function
mipsdsp_mul_q15_q15_overflowflag21().
Signed-off-by: Petar Jovanovic <petar.jovanovic@imgtec.com>
---
target-mips/dsp_helper.c | 4 ++--
tests/tcg/mips/mips32-dsp/mulq_rs_ph.c | 19 ++++++++++++++++++-
2 files changed, 20 insertions(+), 3 deletions(-)
diff --git a/target-mips/dsp_helper.c b/target-mips/dsp_helper.c
index 4116de9..c718a78 100644
--- a/target-mips/dsp_helper.c
+++ b/target-mips/dsp_helper.c
@@ -390,7 +390,7 @@ static inline int32_t mipsdsp_mul_q15_q15_overflowflag21(uint16_t a, uint16_t b,
temp = 0x7FFFFFFF;
set_DSPControl_overflow_flag(1, 21, env);
} else {
- temp = ((int32_t)(int16_t)a * (int32_t)(int16_t)b) << 1;
+ temp = ((int16_t)a * (int16_t)b) << 1;
}
return temp;
@@ -622,7 +622,7 @@ static inline int16_t mipsdsp_rndq15_mul_q15_q15(uint16_t a, uint16_t b,
temp = 0x7FFF0000;
set_DSPControl_overflow_flag(1, 21, env);
} else {
- temp = (a * b) << 1;
+ temp = ((int16_t)a * (int16_t)b) << 1;
temp = temp + 0x00008000;
}
diff --git a/tests/tcg/mips/mips32-dsp/mulq_rs_ph.c b/tests/tcg/mips/mips32-dsp/mulq_rs_ph.c
index c720603..370c2a8 100644
--- a/tests/tcg/mips/mips32-dsp/mulq_rs_ph.c
+++ b/tests/tcg/mips/mips32-dsp/mulq_rs_ph.c
@@ -12,7 +12,24 @@ int main()
resultdsp = 1;
__asm
- ("mulq_rs.ph %0, %2, %3\n\t"
+ ("wrdsp $0\n\t"
+ "mulq_rs.ph %0, %2, %3\n\t"
+ "rddsp %1\n\t"
+ : "=r"(rd), "=r"(dsp)
+ : "r"(rs), "r"(rt)
+ );
+ dsp = (dsp >> 21) & 0x01;
+ assert(rd == result);
+ assert(dsp == resultdsp);
+
+ rs = 0x80011234;
+ rt = 0x80024321;
+ result = 0x7FFD098C;
+ resultdsp = 0;
+
+ __asm
+ ("wrdsp $0\n\t"
+ "mulq_rs.ph %0, %2, %3\n\t"
"rddsp %1\n\t"
: "=r"(rd), "=r"(dsp)
: "r"(rs), "r"(rt)
--
1.7.9.5
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [Qemu-devel] [PATCH] target-mips: fix multiplication in mipsdsp_rndq15_mul_q15_q15
2013-05-23 17:37 [Qemu-devel] [PATCH] target-mips: fix multiplication in mipsdsp_rndq15_mul_q15_q15 Petar Jovanovic
@ 2013-06-09 2:36 ` Petar Jovanovic
2013-06-17 22:40 ` Petar Jovanovic
2013-07-28 16:28 ` Aurelien Jarno
1 sibling, 1 reply; 10+ messages in thread
From: Petar Jovanovic @ 2013-06-09 2:36 UTC (permalink / raw)
To: Petar Jovanovic, qemu-devel@nongnu.org; +Cc: aurelien@aurel32.net
ping
http://patchwork.ozlabs.org/patch/245990/
________________________________________
From: Petar Jovanovic [petar.jovanovic@rt-rk.com]
Sent: Thursday, May 23, 2013 7:37 PM
To: qemu-devel@nongnu.org
Cc: Petar Jovanovic; aurelien@aurel32.net
Subject: [PATCH] target-mips: fix multiplication in mipsdsp_rndq15_mul_q15_q15
From: Petar Jovanovic <petar.jovanovic@imgtec.com>
Multiplication of Q15 fractional halfword vectors was incorrect in the
previous implementation of mipsdsp_rndq15_mul_q15_q15. It failed to take
element signs into account. This change fixes it, and it adds a test case
for it.
The change also removes unnecessary cast in the function
mipsdsp_mul_q15_q15_overflowflag21().
Signed-off-by: Petar Jovanovic <petar.jovanovic@imgtec.com>
---
target-mips/dsp_helper.c | 4 ++--
tests/tcg/mips/mips32-dsp/mulq_rs_ph.c | 19 ++++++++++++++++++-
2 files changed, 20 insertions(+), 3 deletions(-)
diff --git a/target-mips/dsp_helper.c b/target-mips/dsp_helper.c
index 4116de9..c718a78 100644
--- a/target-mips/dsp_helper.c
+++ b/target-mips/dsp_helper.c
@@ -390,7 +390,7 @@ static inline int32_t mipsdsp_mul_q15_q15_overflowflag21(uint16_t a, uint16_t b,
temp = 0x7FFFFFFF;
set_DSPControl_overflow_flag(1, 21, env);
} else {
- temp = ((int32_t)(int16_t)a * (int32_t)(int16_t)b) << 1;
+ temp = ((int16_t)a * (int16_t)b) << 1;
}
return temp;
@@ -622,7 +622,7 @@ static inline int16_t mipsdsp_rndq15_mul_q15_q15(uint16_t a, uint16_t b,
temp = 0x7FFF0000;
set_DSPControl_overflow_flag(1, 21, env);
} else {
- temp = (a * b) << 1;
+ temp = ((int16_t)a * (int16_t)b) << 1;
temp = temp + 0x00008000;
}
diff --git a/tests/tcg/mips/mips32-dsp/mulq_rs_ph.c b/tests/tcg/mips/mips32-dsp/mulq_rs_ph.c
index c720603..370c2a8 100644
--- a/tests/tcg/mips/mips32-dsp/mulq_rs_ph.c
+++ b/tests/tcg/mips/mips32-dsp/mulq_rs_ph.c
@@ -12,7 +12,24 @@ int main()
resultdsp = 1;
__asm
- ("mulq_rs.ph %0, %2, %3\n\t"
+ ("wrdsp $0\n\t"
+ "mulq_rs.ph %0, %2, %3\n\t"
+ "rddsp %1\n\t"
+ : "=r"(rd), "=r"(dsp)
+ : "r"(rs), "r"(rt)
+ );
+ dsp = (dsp >> 21) & 0x01;
+ assert(rd == result);
+ assert(dsp == resultdsp);
+
+ rs = 0x80011234;
+ rt = 0x80024321;
+ result = 0x7FFD098C;
+ resultdsp = 0;
+
+ __asm
+ ("wrdsp $0\n\t"
+ "mulq_rs.ph %0, %2, %3\n\t"
"rddsp %1\n\t"
: "=r"(rd), "=r"(dsp)
: "r"(rs), "r"(rt)
--
1.7.9.5
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [Qemu-devel] [PATCH] target-mips: fix multiplication in mipsdsp_rndq15_mul_q15_q15
2013-06-09 2:36 ` Petar Jovanovic
@ 2013-06-17 22:40 ` Petar Jovanovic
2013-06-25 10:19 ` Petar Jovanovic
2013-06-27 18:26 ` Richard Henderson
0 siblings, 2 replies; 10+ messages in thread
From: Petar Jovanovic @ 2013-06-17 22:40 UTC (permalink / raw)
To: Petar Jovanovic, qemu-devel@nongnu.org; +Cc: aurelien@aurel32.net
ping
________________________________________
From: Petar Jovanovic
Sent: Sunday, June 09, 2013 4:36 AM
To: Petar Jovanovic; qemu-devel@nongnu.org
Cc: aurelien@aurel32.net
Subject: RE: [PATCH] target-mips: fix multiplication in mipsdsp_rndq15_mul_q15_q15
ping
http://patchwork.ozlabs.org/patch/245990/
________________________________________
From: Petar Jovanovic [petar.jovanovic@rt-rk.com]
Sent: Thursday, May 23, 2013 7:37 PM
To: qemu-devel@nongnu.org
Cc: Petar Jovanovic; aurelien@aurel32.net
Subject: [PATCH] target-mips: fix multiplication in mipsdsp_rndq15_mul_q15_q15
From: Petar Jovanovic <petar.jovanovic@imgtec.com>
Multiplication of Q15 fractional halfword vectors was incorrect in the
previous implementation of mipsdsp_rndq15_mul_q15_q15. It failed to take
element signs into account. This change fixes it, and it adds a test case
for it.
The change also removes unnecessary cast in the function
mipsdsp_mul_q15_q15_overflowflag21().
Signed-off-by: Petar Jovanovic <petar.jovanovic@imgtec.com>
---
target-mips/dsp_helper.c | 4 ++--
tests/tcg/mips/mips32-dsp/mulq_rs_ph.c | 19 ++++++++++++++++++-
2 files changed, 20 insertions(+), 3 deletions(-)
diff --git a/target-mips/dsp_helper.c b/target-mips/dsp_helper.c
index 4116de9..c718a78 100644
--- a/target-mips/dsp_helper.c
+++ b/target-mips/dsp_helper.c
@@ -390,7 +390,7 @@ static inline int32_t mipsdsp_mul_q15_q15_overflowflag21(uint16_t a, uint16_t b,
temp = 0x7FFFFFFF;
set_DSPControl_overflow_flag(1, 21, env);
} else {
- temp = ((int32_t)(int16_t)a * (int32_t)(int16_t)b) << 1;
+ temp = ((int16_t)a * (int16_t)b) << 1;
}
return temp;
@@ -622,7 +622,7 @@ static inline int16_t mipsdsp_rndq15_mul_q15_q15(uint16_t a, uint16_t b,
temp = 0x7FFF0000;
set_DSPControl_overflow_flag(1, 21, env);
} else {
- temp = (a * b) << 1;
+ temp = ((int16_t)a * (int16_t)b) << 1;
temp = temp + 0x00008000;
}
diff --git a/tests/tcg/mips/mips32-dsp/mulq_rs_ph.c b/tests/tcg/mips/mips32-dsp/mulq_rs_ph.c
index c720603..370c2a8 100644
--- a/tests/tcg/mips/mips32-dsp/mulq_rs_ph.c
+++ b/tests/tcg/mips/mips32-dsp/mulq_rs_ph.c
@@ -12,7 +12,24 @@ int main()
resultdsp = 1;
__asm
- ("mulq_rs.ph %0, %2, %3\n\t"
+ ("wrdsp $0\n\t"
+ "mulq_rs.ph %0, %2, %3\n\t"
+ "rddsp %1\n\t"
+ : "=r"(rd), "=r"(dsp)
+ : "r"(rs), "r"(rt)
+ );
+ dsp = (dsp >> 21) & 0x01;
+ assert(rd == result);
+ assert(dsp == resultdsp);
+
+ rs = 0x80011234;
+ rt = 0x80024321;
+ result = 0x7FFD098C;
+ resultdsp = 0;
+
+ __asm
+ ("wrdsp $0\n\t"
+ "mulq_rs.ph %0, %2, %3\n\t"
"rddsp %1\n\t"
: "=r"(rd), "=r"(dsp)
: "r"(rs), "r"(rt)
--
1.7.9.5
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [Qemu-devel] [PATCH] target-mips: fix multiplication in mipsdsp_rndq15_mul_q15_q15
2013-06-17 22:40 ` Petar Jovanovic
@ 2013-06-25 10:19 ` Petar Jovanovic
2013-06-27 18:26 ` Richard Henderson
1 sibling, 0 replies; 10+ messages in thread
From: Petar Jovanovic @ 2013-06-25 10:19 UTC (permalink / raw)
To: Petar Jovanovic, qemu-devel@nongnu.org; +Cc: aurelien@aurel32.net
ping
________________________________________
From: Petar Jovanovic
Sent: Tuesday, June 18, 2013 12:40 AM
To: Petar Jovanovic; qemu-devel@nongnu.org
Cc: aurelien@aurel32.net
Subject: RE: [PATCH] target-mips: fix multiplication in mipsdsp_rndq15_mul_q15_q15
ping
________________________________________
From: Petar Jovanovic
Sent: Sunday, June 09, 2013 4:36 AM
To: Petar Jovanovic; qemu-devel@nongnu.org
Cc: aurelien@aurel32.net
Subject: RE: [PATCH] target-mips: fix multiplication in mipsdsp_rndq15_mul_q15_q15
ping
http://patchwork.ozlabs.org/patch/245990/
________________________________________
From: Petar Jovanovic [petar.jovanovic@rt-rk.com]
Sent: Thursday, May 23, 2013 7:37 PM
To: qemu-devel@nongnu.org
Cc: Petar Jovanovic; aurelien@aurel32.net
Subject: [PATCH] target-mips: fix multiplication in mipsdsp_rndq15_mul_q15_q15
From: Petar Jovanovic <petar.jovanovic@imgtec.com>
Multiplication of Q15 fractional halfword vectors was incorrect in the
previous implementation of mipsdsp_rndq15_mul_q15_q15. It failed to take
element signs into account. This change fixes it, and it adds a test case
for it.
The change also removes unnecessary cast in the function
mipsdsp_mul_q15_q15_overflowflag21().
Signed-off-by: Petar Jovanovic <petar.jovanovic@imgtec.com>
---
target-mips/dsp_helper.c | 4 ++--
tests/tcg/mips/mips32-dsp/mulq_rs_ph.c | 19 ++++++++++++++++++-
2 files changed, 20 insertions(+), 3 deletions(-)
diff --git a/target-mips/dsp_helper.c b/target-mips/dsp_helper.c
index 4116de9..c718a78 100644
--- a/target-mips/dsp_helper.c
+++ b/target-mips/dsp_helper.c
@@ -390,7 +390,7 @@ static inline int32_t mipsdsp_mul_q15_q15_overflowflag21(uint16_t a, uint16_t b,
temp = 0x7FFFFFFF;
set_DSPControl_overflow_flag(1, 21, env);
} else {
- temp = ((int32_t)(int16_t)a * (int32_t)(int16_t)b) << 1;
+ temp = ((int16_t)a * (int16_t)b) << 1;
}
return temp;
@@ -622,7 +622,7 @@ static inline int16_t mipsdsp_rndq15_mul_q15_q15(uint16_t a, uint16_t b,
temp = 0x7FFF0000;
set_DSPControl_overflow_flag(1, 21, env);
} else {
- temp = (a * b) << 1;
+ temp = ((int16_t)a * (int16_t)b) << 1;
temp = temp + 0x00008000;
}
diff --git a/tests/tcg/mips/mips32-dsp/mulq_rs_ph.c b/tests/tcg/mips/mips32-dsp/mulq_rs_ph.c
index c720603..370c2a8 100644
--- a/tests/tcg/mips/mips32-dsp/mulq_rs_ph.c
+++ b/tests/tcg/mips/mips32-dsp/mulq_rs_ph.c
@@ -12,7 +12,24 @@ int main()
resultdsp = 1;
__asm
- ("mulq_rs.ph %0, %2, %3\n\t"
+ ("wrdsp $0\n\t"
+ "mulq_rs.ph %0, %2, %3\n\t"
+ "rddsp %1\n\t"
+ : "=r"(rd), "=r"(dsp)
+ : "r"(rs), "r"(rt)
+ );
+ dsp = (dsp >> 21) & 0x01;
+ assert(rd == result);
+ assert(dsp == resultdsp);
+
+ rs = 0x80011234;
+ rt = 0x80024321;
+ result = 0x7FFD098C;
+ resultdsp = 0;
+
+ __asm
+ ("wrdsp $0\n\t"
+ "mulq_rs.ph %0, %2, %3\n\t"
"rddsp %1\n\t"
: "=r"(rd), "=r"(dsp)
: "r"(rs), "r"(rt)
--
1.7.9.5
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [Qemu-devel] [PATCH] target-mips: fix multiplication in mipsdsp_rndq15_mul_q15_q15
2013-06-17 22:40 ` Petar Jovanovic
2013-06-25 10:19 ` Petar Jovanovic
@ 2013-06-27 18:26 ` Richard Henderson
2013-07-08 9:20 ` Petar Jovanovic
1 sibling, 1 reply; 10+ messages in thread
From: Richard Henderson @ 2013-06-27 18:26 UTC (permalink / raw)
To: Petar Jovanovic
Cc: Petar Jovanovic, aurelien@aurel32.net, qemu-devel@nongnu.org
On 06/17/2013 03:40 PM, Petar Jovanovic wrote:
> From: Petar Jovanovic <petar.jovanovic@imgtec.com>
>
> Multiplication of Q15 fractional halfword vectors was incorrect in the
> previous implementation of mipsdsp_rndq15_mul_q15_q15. It failed to take
> element signs into account. This change fixes it, and it adds a test case
> for it.
>
> The change also removes unnecessary cast in the function
> mipsdsp_mul_q15_q15_overflowflag21().
>
> Signed-off-by: Petar Jovanovic <petar.jovanovic@imgtec.com>
> ---
> target-mips/dsp_helper.c | 4 ++--
> tests/tcg/mips/mips32-dsp/mulq_rs_ph.c | 19 ++++++++++++++++++-
> 2 files changed, 20 insertions(+), 3 deletions(-)
Reviewed-by: Richard Henderson <rth@twiddle.net>
r~
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Qemu-devel] [PATCH] target-mips: fix multiplication in mipsdsp_rndq15_mul_q15_q15
2013-06-27 18:26 ` Richard Henderson
@ 2013-07-08 9:20 ` Petar Jovanovic
2013-07-15 11:46 ` Petar Jovanovic
0 siblings, 1 reply; 10+ messages in thread
From: Petar Jovanovic @ 2013-07-08 9:20 UTC (permalink / raw)
To: Richard Henderson
Cc: Petar Jovanovic, aurelien@aurel32.net, qemu-devel@nongnu.org
ping
http://patchwork.ozlabs.org/patch/245990/
________________________________________
From: Richard Henderson [rth7680@gmail.com] on behalf of Richard Henderson [rth@twiddle.net]
Sent: Thursday, June 27, 2013 8:26 PM
To: Petar Jovanovic
Cc: Petar Jovanovic; qemu-devel@nongnu.org; aurelien@aurel32.net
Subject: Re: [Qemu-devel] [PATCH] target-mips: fix multiplication in mipsdsp_rndq15_mul_q15_q15
On 06/17/2013 03:40 PM, Petar Jovanovic wrote:
> From: Petar Jovanovic <petar.jovanovic@imgtec.com>
>
> Multiplication of Q15 fractional halfword vectors was incorrect in the
> previous implementation of mipsdsp_rndq15_mul_q15_q15. It failed to take
> element signs into account. This change fixes it, and it adds a test case
> for it.
>
> The change also removes unnecessary cast in the function
> mipsdsp_mul_q15_q15_overflowflag21().
>
> Signed-off-by: Petar Jovanovic <petar.jovanovic@imgtec.com>
> ---
> target-mips/dsp_helper.c | 4 ++--
> tests/tcg/mips/mips32-dsp/mulq_rs_ph.c | 19 ++++++++++++++++++-
> 2 files changed, 20 insertions(+), 3 deletions(-)
Reviewed-by: Richard Henderson <rth@twiddle.net>
r~
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Qemu-devel] [PATCH] target-mips: fix multiplication in mipsdsp_rndq15_mul_q15_q15
2013-07-08 9:20 ` Petar Jovanovic
@ 2013-07-15 11:46 ` Petar Jovanovic
2013-07-22 8:52 ` Petar Jovanovic
0 siblings, 1 reply; 10+ messages in thread
From: Petar Jovanovic @ 2013-07-15 11:46 UTC (permalink / raw)
To: Richard Henderson
Cc: Petar Jovanovic, aurelien@aurel32.net, qemu-devel@nongnu.org
ping
________________________________________
From: Petar Jovanovic
Sent: Monday, July 08, 2013 11:20 AM
To: Richard Henderson
Cc: Petar Jovanovic; qemu-devel@nongnu.org; aurelien@aurel32.net
Subject: RE: [Qemu-devel] [PATCH] target-mips: fix multiplication in mipsdsp_rndq15_mul_q15_q15
ping
http://patchwork.ozlabs.org/patch/245990/
________________________________________
From: Richard Henderson [rth7680@gmail.com] on behalf of Richard Henderson [rth@twiddle.net]
Sent: Thursday, June 27, 2013 8:26 PM
To: Petar Jovanovic
Cc: Petar Jovanovic; qemu-devel@nongnu.org; aurelien@aurel32.net
Subject: Re: [Qemu-devel] [PATCH] target-mips: fix multiplication in mipsdsp_rndq15_mul_q15_q15
On 06/17/2013 03:40 PM, Petar Jovanovic wrote:
> From: Petar Jovanovic <petar.jovanovic@imgtec.com>
>
> Multiplication of Q15 fractional halfword vectors was incorrect in the
> previous implementation of mipsdsp_rndq15_mul_q15_q15. It failed to take
> element signs into account. This change fixes it, and it adds a test case
> for it.
>
> The change also removes unnecessary cast in the function
> mipsdsp_mul_q15_q15_overflowflag21().
>
> Signed-off-by: Petar Jovanovic <petar.jovanovic@imgtec.com>
> ---
> target-mips/dsp_helper.c | 4 ++--
> tests/tcg/mips/mips32-dsp/mulq_rs_ph.c | 19 ++++++++++++++++++-
> 2 files changed, 20 insertions(+), 3 deletions(-)
Reviewed-by: Richard Henderson <rth@twiddle.net>
r~
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Qemu-devel] [PATCH] target-mips: fix multiplication in mipsdsp_rndq15_mul_q15_q15
2013-07-15 11:46 ` Petar Jovanovic
@ 2013-07-22 8:52 ` Petar Jovanovic
2013-07-27 23:35 ` Petar Jovanovic
0 siblings, 1 reply; 10+ messages in thread
From: Petar Jovanovic @ 2013-07-22 8:52 UTC (permalink / raw)
To: Richard Henderson
Cc: Petar Jovanovic, aurelien@aurel32.net, qemu-devel@nongnu.org
ping
________________________________________
From: Petar Jovanovic
Sent: Monday, July 15, 2013 1:46 PM
To: Richard Henderson
Cc: Petar Jovanovic; qemu-devel@nongnu.org; aurelien@aurel32.net
Subject: RE: [Qemu-devel] [PATCH] target-mips: fix multiplication in mipsdsp_rndq15_mul_q15_q15
ping
________________________________________
From: Petar Jovanovic
Sent: Monday, July 08, 2013 11:20 AM
To: Richard Henderson
Cc: Petar Jovanovic; qemu-devel@nongnu.org; aurelien@aurel32.net
Subject: RE: [Qemu-devel] [PATCH] target-mips: fix multiplication in mipsdsp_rndq15_mul_q15_q15
ping
http://patchwork.ozlabs.org/patch/245990/
________________________________________
From: Richard Henderson [rth7680@gmail.com] on behalf of Richard Henderson [rth@twiddle.net]
Sent: Thursday, June 27, 2013 8:26 PM
To: Petar Jovanovic
Cc: Petar Jovanovic; qemu-devel@nongnu.org; aurelien@aurel32.net
Subject: Re: [Qemu-devel] [PATCH] target-mips: fix multiplication in mipsdsp_rndq15_mul_q15_q15
On 06/17/2013 03:40 PM, Petar Jovanovic wrote:
> From: Petar Jovanovic <petar.jovanovic@imgtec.com>
>
> Multiplication of Q15 fractional halfword vectors was incorrect in the
> previous implementation of mipsdsp_rndq15_mul_q15_q15. It failed to take
> element signs into account. This change fixes it, and it adds a test case
> for it.
>
> The change also removes unnecessary cast in the function
> mipsdsp_mul_q15_q15_overflowflag21().
>
> Signed-off-by: Petar Jovanovic <petar.jovanovic@imgtec.com>
> ---
> target-mips/dsp_helper.c | 4 ++--
> tests/tcg/mips/mips32-dsp/mulq_rs_ph.c | 19 ++++++++++++++++++-
> 2 files changed, 20 insertions(+), 3 deletions(-)
Reviewed-by: Richard Henderson <rth@twiddle.net>
r~
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Qemu-devel] [PATCH] target-mips: fix multiplication in mipsdsp_rndq15_mul_q15_q15
2013-07-22 8:52 ` Petar Jovanovic
@ 2013-07-27 23:35 ` Petar Jovanovic
0 siblings, 0 replies; 10+ messages in thread
From: Petar Jovanovic @ 2013-07-27 23:35 UTC (permalink / raw)
To: Richard Henderson
Cc: Petar Jovanovic, aurelien@aurel32.net, qemu-devel@nongnu.org
ping
Can somebody submit these for 1.6?
Thank you.
Regards,
Petar
________________________________________
From: Petar Jovanovic
Sent: Monday, July 22, 2013 10:52 AM
To: Richard Henderson
Cc: Petar Jovanovic; qemu-devel@nongnu.org; aurelien@aurel32.net
Subject: RE: [Qemu-devel] [PATCH] target-mips: fix multiplication in mipsdsp_rndq15_mul_q15_q15
ping
________________________________________
From: Petar Jovanovic
Sent: Monday, July 15, 2013 1:46 PM
To: Richard Henderson
Cc: Petar Jovanovic; qemu-devel@nongnu.org; aurelien@aurel32.net
Subject: RE: [Qemu-devel] [PATCH] target-mips: fix multiplication in mipsdsp_rndq15_mul_q15_q15
ping
________________________________________
From: Petar Jovanovic
Sent: Monday, July 08, 2013 11:20 AM
To: Richard Henderson
Cc: Petar Jovanovic; qemu-devel@nongnu.org; aurelien@aurel32.net
Subject: RE: [Qemu-devel] [PATCH] target-mips: fix multiplication in mipsdsp_rndq15_mul_q15_q15
ping
http://patchwork.ozlabs.org/patch/245990/
________________________________________
From: Richard Henderson [rth7680@gmail.com] on behalf of Richard Henderson [rth@twiddle.net]
Sent: Thursday, June 27, 2013 8:26 PM
To: Petar Jovanovic
Cc: Petar Jovanovic; qemu-devel@nongnu.org; aurelien@aurel32.net
Subject: Re: [Qemu-devel] [PATCH] target-mips: fix multiplication in mipsdsp_rndq15_mul_q15_q15
On 06/17/2013 03:40 PM, Petar Jovanovic wrote:
> From: Petar Jovanovic <petar.jovanovic@imgtec.com>
>
> Multiplication of Q15 fractional halfword vectors was incorrect in the
> previous implementation of mipsdsp_rndq15_mul_q15_q15. It failed to take
> element signs into account. This change fixes it, and it adds a test case
> for it.
>
> The change also removes unnecessary cast in the function
> mipsdsp_mul_q15_q15_overflowflag21().
>
> Signed-off-by: Petar Jovanovic <petar.jovanovic@imgtec.com>
> ---
> target-mips/dsp_helper.c | 4 ++--
> tests/tcg/mips/mips32-dsp/mulq_rs_ph.c | 19 ++++++++++++++++++-
> 2 files changed, 20 insertions(+), 3 deletions(-)
Reviewed-by: Richard Henderson <rth@twiddle.net>
r~
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Qemu-devel] [PATCH] target-mips: fix multiplication in mipsdsp_rndq15_mul_q15_q15
2013-05-23 17:37 [Qemu-devel] [PATCH] target-mips: fix multiplication in mipsdsp_rndq15_mul_q15_q15 Petar Jovanovic
2013-06-09 2:36 ` Petar Jovanovic
@ 2013-07-28 16:28 ` Aurelien Jarno
1 sibling, 0 replies; 10+ messages in thread
From: Aurelien Jarno @ 2013-07-28 16:28 UTC (permalink / raw)
To: Petar Jovanovic; +Cc: qemu-devel, petar.jovanovic
On Thu, May 23, 2013 at 07:37:53PM +0200, Petar Jovanovic wrote:
> From: Petar Jovanovic <petar.jovanovic@imgtec.com>
>
> Multiplication of Q15 fractional halfword vectors was incorrect in the
> previous implementation of mipsdsp_rndq15_mul_q15_q15. It failed to take
> element signs into account. This change fixes it, and it adds a test case
> for it.
>
> The change also removes unnecessary cast in the function
> mipsdsp_mul_q15_q15_overflowflag21().
>
> Signed-off-by: Petar Jovanovic <petar.jovanovic@imgtec.com>
> ---
> target-mips/dsp_helper.c | 4 ++--
> tests/tcg/mips/mips32-dsp/mulq_rs_ph.c | 19 ++++++++++++++++++-
> 2 files changed, 20 insertions(+), 3 deletions(-)
>
> diff --git a/target-mips/dsp_helper.c b/target-mips/dsp_helper.c
> index 4116de9..c718a78 100644
> --- a/target-mips/dsp_helper.c
> +++ b/target-mips/dsp_helper.c
> @@ -390,7 +390,7 @@ static inline int32_t mipsdsp_mul_q15_q15_overflowflag21(uint16_t a, uint16_t b,
> temp = 0x7FFFFFFF;
> set_DSPControl_overflow_flag(1, 21, env);
> } else {
> - temp = ((int32_t)(int16_t)a * (int32_t)(int16_t)b) << 1;
> + temp = ((int16_t)a * (int16_t)b) << 1;
> }
>
> return temp;
> @@ -622,7 +622,7 @@ static inline int16_t mipsdsp_rndq15_mul_q15_q15(uint16_t a, uint16_t b,
> temp = 0x7FFF0000;
> set_DSPControl_overflow_flag(1, 21, env);
> } else {
> - temp = (a * b) << 1;
> + temp = ((int16_t)a * (int16_t)b) << 1;
> temp = temp + 0x00008000;
> }
>
> diff --git a/tests/tcg/mips/mips32-dsp/mulq_rs_ph.c b/tests/tcg/mips/mips32-dsp/mulq_rs_ph.c
> index c720603..370c2a8 100644
> --- a/tests/tcg/mips/mips32-dsp/mulq_rs_ph.c
> +++ b/tests/tcg/mips/mips32-dsp/mulq_rs_ph.c
> @@ -12,7 +12,24 @@ int main()
> resultdsp = 1;
>
> __asm
> - ("mulq_rs.ph %0, %2, %3\n\t"
> + ("wrdsp $0\n\t"
> + "mulq_rs.ph %0, %2, %3\n\t"
> + "rddsp %1\n\t"
> + : "=r"(rd), "=r"(dsp)
> + : "r"(rs), "r"(rt)
> + );
> + dsp = (dsp >> 21) & 0x01;
> + assert(rd == result);
> + assert(dsp == resultdsp);
> +
> + rs = 0x80011234;
> + rt = 0x80024321;
> + result = 0x7FFD098C;
> + resultdsp = 0;
> +
> + __asm
> + ("wrdsp $0\n\t"
> + "mulq_rs.ph %0, %2, %3\n\t"
> "rddsp %1\n\t"
> : "=r"(rd), "=r"(dsp)
> : "r"(rs), "r"(rt)
Thanks, applied, sorry for the delay.
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2013-07-28 16:29 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-23 17:37 [Qemu-devel] [PATCH] target-mips: fix multiplication in mipsdsp_rndq15_mul_q15_q15 Petar Jovanovic
2013-06-09 2:36 ` Petar Jovanovic
2013-06-17 22:40 ` Petar Jovanovic
2013-06-25 10:19 ` Petar Jovanovic
2013-06-27 18:26 ` Richard Henderson
2013-07-08 9:20 ` Petar Jovanovic
2013-07-15 11:46 ` Petar Jovanovic
2013-07-22 8:52 ` Petar Jovanovic
2013-07-27 23:35 ` Petar Jovanovic
2013-07-28 16:28 ` Aurelien Jarno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).