From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55742)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1V3Ucm-0006SN-5H
	for qemu-devel@nongnu.org; Sun, 28 Jul 2013 13:19:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1V3Ucg-00057K-O8
	for qemu-devel@nongnu.org; Sun, 28 Jul 2013 13:19:16 -0400
Received: from mx1.redhat.com ([209.132.183.28]:63664)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1V3Ucg-00057C-Ge
	for qemu-devel@nongnu.org; Sun, 28 Jul 2013 13:19:10 -0400
Date: Sun, 28 Jul 2013 19:19:06 +0200
From: Igor Mammedov <imammedo@redhat.com>
Message-ID: <20130728191906.2e43c926@thinkpad>
In-Reply-To: <51F4EA66.6010001@suse.de>
References: <1374996553-21828-1-git-send-email-imammedo@redhat.com>
	<1374996553-21828-2-git-send-email-imammedo@redhat.com>
	<51F4EA66.6010001@suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 1/6] pc: move IO_APIC_DEFAULT_ADDRESS to
 include/hw/i386/ioapic.h
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andreas =?ISO-8859-1?B?RuRyYmVy?= <afaerber@suse.de>
Cc: qemu-devel@nongnu.org, mst@redhat.com

On Sun, 28 Jul 2013 11:54:46 +0200
Andreas F=E4rber <afaerber@suse.de> wrote:

> Am 28.07.2013 09:29, schrieb Igor Mammedov:
> > From: "Michael S. Tsirkin" <mst@redhat.com>
> >=20
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > Signed-off-by: Laszlo Ersek <lersek@redhat.com>
>=20
> Missing Reviewed-bys from Gerd and me.
it changed file form apic.h to ioapic.h, so I haven't felt comfortble adding
yours Reviewed-bys.
I sure can add it if it's ok.=20

>=20
> Andreas
>=20
> > Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> > ---
> >  hw/i386/pc.c             | 2 --
> >  include/hw/i386/ioapic.h | 1 +
> >  2 files changed, 1 insertion(+), 2 deletions(-)
> >=20
> > diff --git a/hw/i386/pc.c b/hw/i386/pc.c
> > index 2a87563..b0b98a8 100644
> > --- a/hw/i386/pc.c
> > +++ b/hw/i386/pc.c
> > @@ -75,8 +75,6 @@
> >  #define FW_CFG_E820_TABLE (FW_CFG_ARCH_LOCAL + 3)
> >  #define FW_CFG_HPET (FW_CFG_ARCH_LOCAL + 4)
> > =20
> > -#define IO_APIC_DEFAULT_ADDRESS 0xfec00000
> > -
> >  #define E820_NR_ENTRIES		16
> > =20
> >  struct e820_entry {
> > diff --git a/include/hw/i386/ioapic.h b/include/hw/i386/ioapic.h
> > index 86e63da..6245388 100644
> > --- a/include/hw/i386/ioapic.h
> > +++ b/include/hw/i386/ioapic.h
> > @@ -21,6 +21,7 @@
> >  #define HW_IOAPIC_H
> > =20
> >  #define IOAPIC_NUM_PINS 24
> > +#define IO_APIC_DEFAULT_ADDRESS 0xfec00000
> > =20
> >  void ioapic_eoi_broadcast(int vector);
> > =20
> >=20
>=20
>=20
> --=20
> SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
> GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg


--=20
Regards,
  Igor