From: Aurelien Jarno <aurelien@aurel32.net>
To: Stefan Weil <sw@weilnetz.de>
Cc: qemu-trivial <qemu-trivial@nongnu.org>,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] target-mips: Remove assignment to a variable which is never used
Date: Mon, 29 Jul 2013 00:37:10 +0200 [thread overview]
Message-ID: <20130728223710.GF10155@hall.aurel32.net> (raw)
In-Reply-To: <1374783031-26633-1-git-send-email-sw@weilnetz.de>
On Thu, Jul 25, 2013 at 10:10:31PM +0200, Stefan Weil wrote:
> This assignment causes a compiler warning for compilations with the compiler
> option -Wunused-but-set-variable (which is included with -Wextra).
>
> Removing it allows using -Wextra for QEMU code without suppressing too many
> extra warnings.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
> target-mips/op_helper.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/target-mips/op_helper.c b/target-mips/op_helper.c
> index 5cf1c3f..b828375 100644
> --- a/target-mips/op_helper.c
> +++ b/target-mips/op_helper.c
> @@ -1735,7 +1735,6 @@ target_ulong helper_evpe(CPUMIPSState *env)
> void helper_fork(target_ulong arg1, target_ulong arg2)
> {
> // arg1 = rt, arg2 = rs
> - arg1 = 0;
> // TODO: store to TC register
> }
>
Thanks, applied.
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
next prev parent reply other threads:[~2013-07-28 22:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-25 20:10 [Qemu-devel] [PATCH] target-mips: Remove assignment to a variable which is never used Stefan Weil
2013-07-27 7:22 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2013-07-28 22:37 ` Aurelien Jarno [this message]
2013-07-29 6:13 ` Michael Tokarev
2013-07-29 7:41 ` Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130728223710.GF10155@hall.aurel32.net \
--to=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).