From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56083)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1V3ZaW-0000Rh-8U
	for qemu-devel@nongnu.org; Sun, 28 Jul 2013 18:37:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1V3ZaR-0005it-9O
	for qemu-devel@nongnu.org; Sun, 28 Jul 2013 18:37:16 -0400
Received: from hall.aurel32.net ([2001:470:1f0b:4a8::1]:55307)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1V3ZaR-0005im-21
	for qemu-devel@nongnu.org; Sun, 28 Jul 2013 18:37:11 -0400
Date: Mon, 29 Jul 2013 00:37:10 +0200
From: Aurelien Jarno <aurelien@aurel32.net>
Message-ID: <20130728223710.GF10155@hall.aurel32.net>
References: <1374783031-26633-1-git-send-email-sw@weilnetz.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <1374783031-26633-1-git-send-email-sw@weilnetz.de>
Sender: Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH] target-mips: Remove assignment to a
 variable which is never used
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <sw@weilnetz.de>
Cc: qemu-trivial <qemu-trivial@nongnu.org>, qemu-devel <qemu-devel@nongnu.org>

On Thu, Jul 25, 2013 at 10:10:31PM +0200, Stefan Weil wrote:
> This assignment causes a compiler warning for compilations with the compiler
> option -Wunused-but-set-variable (which is included with -Wextra).
> 
> Removing it allows using -Wextra for QEMU code without suppressing too many
> extra warnings.
> 
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
>  target-mips/op_helper.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/target-mips/op_helper.c b/target-mips/op_helper.c
> index 5cf1c3f..b828375 100644
> --- a/target-mips/op_helper.c
> +++ b/target-mips/op_helper.c
> @@ -1735,7 +1735,6 @@ target_ulong helper_evpe(CPUMIPSState *env)
>  void helper_fork(target_ulong arg1, target_ulong arg2)
>  {
>      // arg1 = rt, arg2 = rs
> -    arg1 = 0;
>      // TODO: store to TC register
>  }
>  

Thanks, applied.


-- 
Aurelien Jarno	                        GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net