Re: [Qemu-devel] [PATCH] linux-user: correct argument number for sys_mremap and sys_splice

[Aurelien Jarno <aurelien@aurel32.net>]

On Tue, Jul 23, 2013 at 07:00:10PM +0200, Petar Jovanovic wrote:
> From: Petar Jovanovic <petar.jovanovic@imgtec.com>
> 
> sys_mremap missed 5th argument (new_address), which caused examples that
> remap to a specific address to fail.
> sys_splice missed 5th and 6th argument which caused different examples to
> fail.
> This change has an effect on MIPS target only.
> 
> Signed-off-by: Petar Jovanovic <petar.jovanovic@imgtec.com>
> ---
>  linux-user/main.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/linux-user/main.c b/linux-user/main.c
> index 99c3b3f..1c20229 100644
> --- a/linux-user/main.c
> +++ b/linux-user/main.c
> @@ -1957,7 +1957,7 @@ static const uint8_t mips_syscall_args[] = {
>  	MIPS_SYS(sys_sched_get_priority_min, 1)
>  	MIPS_SYS(sys_sched_rr_get_interval, 2)	/* 4165 */
>  	MIPS_SYS(sys_nanosleep,	2)
> -	MIPS_SYS(sys_mremap	, 4)
> +	MIPS_SYS(sys_mremap	, 5)
>  	MIPS_SYS(sys_accept	, 3)
>  	MIPS_SYS(sys_bind	, 3)
>  	MIPS_SYS(sys_connect	, 3)	/* 4170 */
> @@ -2094,7 +2094,7 @@ static const uint8_t mips_syscall_args[] = {
>  	MIPS_SYS(sys_pselect6, 6)
>  	MIPS_SYS(sys_ppoll, 5)
>  	MIPS_SYS(sys_unshare, 1)
> -	MIPS_SYS(sys_splice, 4)
> +	MIPS_SYS(sys_splice, 6)
>  	MIPS_SYS(sys_sync_file_range, 7) /* 4305 */
>  	MIPS_SYS(sys_tee, 4)
>  	MIPS_SYS(sys_vmsplice, 4)

Thanks, applied.


-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net