From: "Michael S. Tsirkin" <mst@redhat.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Andreas Färber" <afaerber@suse.de>,
"Anthony Liguori" <anthony@codemonkey.ws>,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] vhost acceleration broken?
Date: Mon, 29 Jul 2013 10:09:48 +0300 [thread overview]
Message-ID: <20130729070948.GB2308@redhat.com> (raw)
In-Reply-To: <8738qy8ck7.fsf@rustcorp.com.au>
On Mon, Jul 29, 2013 at 09:25:20AM +0930, Rusty Russell wrote:
> Anthony Liguori <anthony@codemonkey.ws> writes:
> > "Michael S. Tsirkin" <mst@redhat.com> writes:
> >
> >> On Thu, Jul 25, 2013 at 04:56:05PM +0200, Andreas Färber wrote:
> >>> Am 25.07.2013 16:52, schrieb Michael S. Tsirkin:
> >>> > On Thu, Jul 25, 2013 at 08:28:00AM -0500, Anthony Liguori wrote:
> >>> >> We have a pretty awful legacy command line set that comes from years of
> >>> >> half-baked concepts and the years when too many people just committed
> >>> >> random shit to the tree.
> >>> >>
> >>> >> I think we probably need to start planning for a clean break. Maybe
> >>> >> that's a good target for a 2.0 version...
> >>> >
> >>> > Assuming -netdev supports all required configurations, we should
> >>> > remove -net from the -help output.
> >>>
> >>> Peter had raised the issue of -netdev not working well with boards that
> >>> already supply a default NIC - was there a solution yet?
> >>>
> >>> Andreas
> >>
> >> Whoever is removing -net will have to code that up. Want to do this?
> >
> > I would not rush to remove things. If we're going to go through a
> > deprecation process, we should start with a proposal on what things
> > should be removed and go from there.
> >
> > I still don't even think -netdev is the right answer here either.
> > Wouldn't it make more sense to have something like:
> >
> > qemu -vnic tap,script=/foo/myscript
> >
> > Or something vaguely understandable by a human?
>
> OK. It seems to me that each net device has a host side and a guest
> side, which you can mix and match. So the commandline should reflect
> that explicitly:
>
> qemu -hostdev net,[tap|user|bridge|socket|vde],.... -guestdev net,....
>
> If you have a built-in net device on your emulated board, you've got one
> implied -guestdev net. And similar principles apply to other things
> like consoles and disks.
I think what Peter was asking for is a way to set parameters
on the implied -guestdev (we use -netdev for this).
> Now, guest and host terms may suck. But please pick one terminology and
> use it *everywhere*. Documentation, code and cmdline.
>
> Thanks,
> Rusty.
next prev parent reply other threads:[~2013-07-29 7:08 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-25 1:55 [Qemu-devel] vhost acceleration broken? Rusty Russell
2013-07-25 2:08 ` Anthony Liguori
2013-07-25 3:07 ` Rusty Russell
2013-07-25 13:28 ` Anthony Liguori
2013-07-25 14:52 ` Michael S. Tsirkin
2013-07-25 14:56 ` Andreas Färber
2013-07-25 15:24 ` Michael S. Tsirkin
2013-07-25 16:16 ` Anthony Liguori
2013-07-25 16:20 ` Peter Maydell
2013-07-25 16:32 ` Michael S. Tsirkin
2013-07-28 23:55 ` Rusty Russell
2013-07-29 2:10 ` Anthony Liguori
2013-07-29 7:33 ` Michael S. Tsirkin
2013-07-29 7:09 ` Michael S. Tsirkin [this message]
2013-07-25 14:12 ` Peter Maydell
2013-07-25 14:53 ` Michael S. Tsirkin
2013-07-26 9:25 ` Stefan Hajnoczi
2013-07-26 9:43 ` Peter Maydell
2013-07-28 8:10 ` Michael S. Tsirkin
2013-07-25 5:20 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130729070948.GB2308@redhat.com \
--to=mst@redhat.com \
--cc=afaerber@suse.de \
--cc=anthony@codemonkey.ws \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rusty@rustcorp.com.au \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).