From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39348)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1V3hwQ-00078w-6Z
	for qemu-devel@nongnu.org; Mon, 29 Jul 2013 03:32:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1V3hwL-0004Cz-2T
	for qemu-devel@nongnu.org; Mon, 29 Jul 2013 03:32:26 -0400
Received: from mx1.redhat.com ([209.132.183.28]:24702)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1V3hwK-0004Ck-Oq
	for qemu-devel@nongnu.org; Mon, 29 Jul 2013 03:32:20 -0400
Date: Mon, 29 Jul 2013 10:33:41 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20130729073341.GC2308@redhat.com>
References: <87li4v8ktz.fsf@rustcorp.com.au>
	<CA+aC4ksBr62tX1aiAXnVueixgyvgFu5uq17TEiD8sZRKD_Tp3w@mail.gmail.com>
	<87ehan8hhn.fsf@rustcorp.com.au> <87ppu66a73.fsf@codemonkey.ws>
	<20130725145215.GA3758@redhat.com> <51F13C85.8050108@suse.de>
	<20130725152427.GH3758@redhat.com> <87iozybonc.fsf@codemonkey.ws>
	<8738qy8ck7.fsf@rustcorp.com.au>
	<CA+aC4ksrU2--yYsO-LZqWBjAunKQyuHLaTR+gJB-p_mW3eWX+Q@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CA+aC4ksrU2--yYsO-LZqWBjAunKQyuHLaTR+gJB-p_mW3eWX+Q@mail.gmail.com>
Subject: Re: [Qemu-devel] vhost acceleration broken?
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Peter Maydell <peter.maydell@linaro.org>, Rusty Russell <rusty@rustcorp.com.au>, Andreas =?iso-8859-1?Q?F=E4rber?= <afaerber@suse.de>, Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel <qemu-devel@nongnu.org>

On Sun, Jul 28, 2013 at 09:10:16PM -0500, Anthony Liguori wrote:
> On Sun, Jul 28, 2013 at 6:55 PM, Rusty Russell <rusty@rustcorp.com.au> wrote:
> >> Or something vaguely understandable by a human?
> >
> > OK.  It seems to me that each net device has a host side and a guest
> > side, which you can mix and match.  So the commandline should reflect
> > that explicitly:
> >
> >         qemu -hostdev net,[tap|user|bridge|socket|vde],....  -guestdev net,....
> >
> > If you have a built-in net device on your emulated board, you've got one
> > implied -guestdev net.  And similar principles apply to other things
> > like consoles and disks.
> 
> See, we have this:
> 
> qemu -netdev tap,...  -device virtio-net-pci,...
> 
> > Now, guest and host terms may suck.  But please pick one terminology and
> > use it *everywhere*.  Documentation, code and cmdline.
> 
> But *this* is the problem.

It's not the only problem though. Here's a list off the
top of my head.

Use of -device lacks documentation almost completely
(Marcel's recent patches are a step in the right
direction here), many devices also lack any user-readable
description, legal parameters to -global are undocumented,
-global does not validate parameters,
device properties are undocumented,
bus address formats are undocumented,
for complex devices such as pci express switches,
which device can be connected to which is
also undocumented.


> Our documentation (man page, --help,
> qemu-doc.texi) hasn't been touched since the beginning.  I get the
> feedback, will take a look at it for 1.7.
> 
> Regards,
> 
> Anthony Liguori
> 
> > Thanks,
> > Rusty.