From: Kevin Wolf <kwolf@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: pl@kamp.de, qemu-devel@nongnu.org, stefanha@redhat.com,
Charlie Shepherd <charlie@ctshepherd.com>
Subject: Re: [Qemu-devel] [PATCH v3 05/19] block: make bdrv_co_is_allocated static
Date: Mon, 29 Jul 2013 15:21:29 +0200 [thread overview]
Message-ID: <20130729132129.GE10467@dhcp-200-207.str.redhat.com> (raw)
In-Reply-To: <1374762197-7261-6-git-send-email-pbonzini@redhat.com>
Am 25.07.2013 um 16:23 hat Paolo Bonzini geschrieben:
> bdrv_is_allocated can detect coroutine context and go through a fast
> path, similar to other block layer functions.
>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
It can, but why is this a good idea?
The other block layer functions do this because existing drivers call
bdrv_(p)read/write(v) and we don't want them to block the vcpu. So it's
basically just a method of avoiding massive changes to existing callers.
The only such caller of bdrv_is_allocated() that I can see is vvfat, and
I don't think optimising that is our top priority.
Charlie is working in exactly the opposite direction, namely splitting
the existing functions in a coroutine-only and a synchronous-only part.
We should be clear what we really want here.
Kevin
next prev parent reply other threads:[~2013-07-29 13:21 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-25 14:22 [Qemu-devel] [PATCH v3 00/19] Add qemu-img subcommand to dump file metadata Paolo Bonzini
2013-07-25 14:22 ` [Qemu-devel] [PATCH v3 01/19] cow: make reads go at a decent speed Paolo Bonzini
2013-07-25 14:23 ` [Qemu-devel] [PATCH v3 02/19] cow: make writes go at a less indecent speed Paolo Bonzini
2013-07-25 14:23 ` [Qemu-devel] [PATCH v3 03/19] cow: do not call bdrv_co_is_allocated Paolo Bonzini
2013-07-29 13:22 ` Kevin Wolf
2013-07-25 14:23 ` [Qemu-devel] [PATCH v3 04/19] block: update bs->total_sectors on writes Paolo Bonzini
2013-07-29 13:13 ` Kevin Wolf
2013-07-29 13:47 ` Paolo Bonzini
2013-07-29 14:10 ` Kevin Wolf
2013-07-29 14:18 ` Paolo Bonzini
2013-08-02 7:05 ` Peter Lieven
2013-08-17 6:27 ` Paolo Bonzini
2013-09-02 7:12 ` Peter Lieven
2013-07-25 14:23 ` [Qemu-devel] [PATCH v3 05/19] block: make bdrv_co_is_allocated static Paolo Bonzini
2013-07-29 13:21 ` Kevin Wolf [this message]
2013-07-29 13:56 ` Paolo Bonzini
2013-07-25 14:23 ` [Qemu-devel] [PATCH v3 06/19] block: remove bdrv_is_allocated_above/bdrv_co_is_allocated_above distinction Paolo Bonzini
2013-07-29 13:34 ` Kevin Wolf
2013-07-29 13:59 ` Paolo Bonzini
2013-07-29 14:15 ` Kevin Wolf
2013-07-25 14:23 ` [Qemu-devel] [PATCH v3 07/19] block: expect errors from bdrv_co_is_allocated Paolo Bonzini
2013-07-29 13:43 ` Kevin Wolf
2013-07-29 14:03 ` Paolo Bonzini
2013-07-29 14:17 ` Kevin Wolf
2013-07-25 14:23 ` [Qemu-devel] [PATCH v3 08/19] qemu-img: always probe the input image for allocated sectors Paolo Bonzini
2013-07-25 14:23 ` [Qemu-devel] [PATCH v3 09/19] block: make bdrv_has_zero_init return false for copy-on-write-images Paolo Bonzini
2013-07-25 14:23 ` [Qemu-devel] [PATCH v3 10/19] block: introduce bdrv_get_block_status API Paolo Bonzini
2013-07-25 14:23 ` [Qemu-devel] [PATCH v3 11/19] block: define get_block_status return value Paolo Bonzini
2013-07-30 14:14 ` Kevin Wolf
2013-07-30 14:19 ` Paolo Bonzini
2013-07-30 14:26 ` Kevin Wolf
2013-07-25 14:23 ` [Qemu-devel] [PATCH v3 12/19] block: return get_block_status data and flags for formats Paolo Bonzini
2013-07-30 14:40 ` Kevin Wolf
2013-07-30 15:15 ` Paolo Bonzini
2013-07-30 15:23 ` Kevin Wolf
2013-07-25 14:23 ` [Qemu-devel] [PATCH v3 13/19] qemu-img: add a "map" subcommand Paolo Bonzini
2013-07-30 15:13 ` Kevin Wolf
2013-07-30 15:22 ` Paolo Bonzini
2013-07-30 15:30 ` Kevin Wolf
2013-07-31 8:57 ` Kevin Wolf
2013-07-31 12:13 ` Paolo Bonzini
2013-07-31 13:26 ` Kevin Wolf
2013-07-25 14:23 ` [Qemu-devel] [PATCH v3 14/19] docs, qapi: document qemu-img map Paolo Bonzini
2013-07-30 15:48 ` Eric Blake
2013-07-30 15:54 ` Paolo Bonzini
2013-07-25 14:23 ` [Qemu-devel] [PATCH v3 15/19] block: use bdrv_has_zero_init to return BDRV_BLOCK_ZERO Paolo Bonzini
2013-07-31 9:16 ` Kevin Wolf
2013-07-25 14:23 ` [Qemu-devel] [PATCH v3 16/19] raw-posix: return get_block_status data and flags Paolo Bonzini
2013-07-25 14:23 ` [Qemu-devel] [PATCH v3 17/19] raw-posix: detect XFS unwritten extents Paolo Bonzini
2013-07-25 14:23 ` [Qemu-devel] [PATCH v3 18/19] block: add default get_block_status implementation for protocols Paolo Bonzini
2013-07-31 9:12 ` Kevin Wolf
2013-07-31 12:49 ` Paolo Bonzini
2013-07-25 14:23 ` [Qemu-devel] [PATCH v3 19/19] block: look for zero blocks in bs->file Paolo Bonzini
2013-07-31 9:21 ` Kevin Wolf
2013-07-31 12:53 ` Paolo Bonzini
2013-08-16 15:30 ` [Qemu-devel] [PATCH v3 00/19] Add qemu-img subcommand to dump file metadata Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130729132129.GE10467@dhcp-200-207.str.redhat.com \
--to=kwolf@redhat.com \
--cc=charlie@ctshepherd.com \
--cc=pbonzini@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).