From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57646) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V3oHO-0007Ob-SQ for qemu-devel@nongnu.org; Mon, 29 Jul 2013 10:18:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V3oHJ-0000Q6-Qj for qemu-devel@nongnu.org; Mon, 29 Jul 2013 10:18:30 -0400 Date: Mon, 29 Jul 2013 16:17:52 +0200 From: Kevin Wolf Message-ID: <20130729141751.GL10467@dhcp-200-207.str.redhat.com> References: <1374762197-7261-1-git-send-email-pbonzini@redhat.com> <1374762197-7261-8-git-send-email-pbonzini@redhat.com> <20130729134349.GI10467@dhcp-200-207.str.redhat.com> <51F67643.4030108@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <51F67643.4030108@redhat.com> Subject: Re: [Qemu-devel] [PATCH v3 07/19] block: expect errors from bdrv_co_is_allocated List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: pl@kamp.de, qemu-devel@nongnu.org, stefanha@redhat.com, qemu-stable@nongnu.org Am 29.07.2013 um 16:03 hat Paolo Bonzini geschrieben: > Il 29/07/2013 15:43, Kevin Wolf ha scritto: > > Am 25.07.2013 um 16:23 hat Paolo Bonzini geschrieben: > >> Some bdrv_is_allocated callers do not expect errors, but the fallback > >> in qcow2.c might make other callers trip on assertion failures or > >> infinite loops. > >> > >> Fix the callers to always look for errors. > >> > >> Cc: qemu-stable@nongnu.org > >> Reviewed-by: Eric Blake > >> Signed-off-by: Paolo Bonzini > > > > Good idea, but there seem to be a few more callers that don't handle > > errors yet. Not sure what your criterion for fixing callers or not was. > > Did you simply miss the rest? > > In general, I didn't bother about callers that didn't handle *pnum = 0 > correctly (for example block-migration.c and commit). But I see now > that the ones in qemu-io-cmds.c are due to a bad rebase. Would you mind fixing the already broken ones as well? > (BTW, I just noticed now that both block-migration.c and commit also run > outside a coroutine, and thus rely on bdrv_is_allocated creating one). Ah well, I missed those, too bad. I won't insist on removing the synchronous path then. Kevin