From: Stefan Hajnoczi <stefanha@redhat.com>
To: Vincenzo Maffione <v.maffione@gmail.com>
Cc: aliguori@us.ibm.com, mst@redhat.com, rizzo@iet.unipi.it,
jasowang@redhat.com, qemu-devel@nongnu.org, pbonzini@redhat.com,
g.lettieri@iet.unipi.it, lersek@redhat.com, afaerber@suse.de
Subject: Re: [Qemu-devel] [PATCH v3] e1000: add interrupt mitigation support
Date: Mon, 29 Jul 2013 16:23:10 +0200 [thread overview]
Message-ID: <20130729142310.GB4467@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1374850970-4851-1-git-send-email-v.maffione@gmail.com>
On Fri, Jul 26, 2013 at 05:02:50PM +0200, Vincenzo Maffione wrote:
> +static const VMStateDescription vmstate_e1000_mit_state = {
> + .name = "e1000/mit_state",
> + .version_id = 1,
> + .minimum_version_id = 1,
> + .minimum_version_id_old = 1,
> + .fields = (VMStateField[]) {
> + VMSTATE_UINT32(mac_reg[RDTR], E1000State),
> + VMSTATE_UINT32(mac_reg[RADV], E1000State),
> + VMSTATE_UINT32(mac_reg[TADV], E1000State),
> + VMSTATE_UINT32(mac_reg[ITR], E1000State),
> + VMSTATE_BOOL(mit_timer_on, E1000State),
Why is this migrated? I it is always 0 since pre_save calls
set_interrupt_cause(s, 0, s->mac_reg[ICR]).
next prev parent reply other threads:[~2013-07-29 14:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-26 15:02 [Qemu-devel] [PATCH v3] e1000: add interrupt mitigation support Vincenzo Maffione
2013-07-29 14:23 ` Stefan Hajnoczi [this message]
2013-07-29 14:46 ` Vincenzo Maffione
2013-07-30 10:44 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130729142310.GB4467@stefanha-thinkpad.redhat.com \
--to=stefanha@redhat.com \
--cc=afaerber@suse.de \
--cc=aliguori@us.ibm.com \
--cc=g.lettieri@iet.unipi.it \
--cc=jasowang@redhat.com \
--cc=lersek@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rizzo@iet.unipi.it \
--cc=v.maffione@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).