From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59034)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1V3oM9-0007JL-Gm
	for qemu-devel@nongnu.org; Mon, 29 Jul 2013 10:23:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1V3oM3-00026e-Hr
	for qemu-devel@nongnu.org; Mon, 29 Jul 2013 10:23:25 -0400
Received: from mx1.redhat.com ([209.132.183.28]:59934)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1V3oM3-00026R-Aj
	for qemu-devel@nongnu.org; Mon, 29 Jul 2013 10:23:19 -0400
Date: Mon, 29 Jul 2013 16:23:10 +0200
From: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20130729142310.GB4467@stefanha-thinkpad.redhat.com>
References: <1374850970-4851-1-git-send-email-v.maffione@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1374850970-4851-1-git-send-email-v.maffione@gmail.com>
Subject: Re: [Qemu-devel] [PATCH v3] e1000: add interrupt mitigation support
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Vincenzo Maffione <v.maffione@gmail.com>
Cc: aliguori@us.ibm.com, mst@redhat.com, rizzo@iet.unipi.it, jasowang@redhat.com, qemu-devel@nongnu.org, pbonzini@redhat.com, g.lettieri@iet.unipi.it, lersek@redhat.com, afaerber@suse.de

On Fri, Jul 26, 2013 at 05:02:50PM +0200, Vincenzo Maffione wrote:
> +static const VMStateDescription vmstate_e1000_mit_state = {
> +    .name = "e1000/mit_state",
> +    .version_id = 1,
> +    .minimum_version_id = 1,
> +    .minimum_version_id_old = 1,
> +    .fields    = (VMStateField[]) {
> +        VMSTATE_UINT32(mac_reg[RDTR], E1000State),
> +        VMSTATE_UINT32(mac_reg[RADV], E1000State),
> +        VMSTATE_UINT32(mac_reg[TADV], E1000State),
> +        VMSTATE_UINT32(mac_reg[ITR], E1000State),
> +        VMSTATE_BOOL(mit_timer_on, E1000State),

Why is this migrated?  I it is always 0 since pre_save calls
set_interrupt_cause(s, 0, s->mac_reg[ICR]).