From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52104)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1V3sid-0004g6-Fm
	for qemu-devel@nongnu.org; Mon, 29 Jul 2013 15:03:01 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1V3siX-0004oS-Hm
	for qemu-devel@nongnu.org; Mon, 29 Jul 2013 15:02:55 -0400
Received: from mx1.redhat.com ([209.132.183.28]:12739)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1V3siX-0004oN-Aq
	for qemu-devel@nongnu.org; Mon, 29 Jul 2013 15:02:49 -0400
Date: Mon, 29 Jul 2013 15:02:43 -0400
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20130729150243.13e9c37b@redhat.com>
In-Reply-To: <1374200625-7125-1-git-send-email-p.pawit@gmail.com>
References: <1374200625-7125-1-git-send-email-p.pawit@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] migration: send total time in QMP at
 "completed" stage
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Pawit Pornkitprasan <p.pawit@gmail.com>
Cc: Ryousei Takano <takano-ryousei@aist.go.jp>, qemu-devel@nongnu.org, Juan Quintela <quintela@redhat.com>

On Fri, 19 Jul 2013 11:23:45 +0900
Pawit Pornkitprasan <p.pawit@gmail.com> wrote:

> The "completed" stage sets total_time but not has_total_time and
> thus it is not sent via QMP reply (but sent via HMP nevertheless)
> 
> Signed-off-by: Pawit Pornkitprasan <p.pawit@gmail.com>

Applied to the qmp branch, thanks.

> ---
>  migration.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/migration.c b/migration.c
> index 9f5a423..4c16f2e 100644
> --- a/migration.c
> +++ b/migration.c
> @@ -219,6 +219,7 @@ MigrationInfo *qmp_query_migrate(Error **errp)
>  
>          info->has_status = true;
>          info->status = g_strdup("completed");
> +        info->has_total_time = true;
>          info->total_time = s->total_time;
>          info->has_downtime = true;
>          info->downtime = s->downtime;