From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57499)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1V3uri-0001PM-PJ
	for qemu-devel@nongnu.org; Mon, 29 Jul 2013 17:20:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1V3ure-0007FL-Kt
	for qemu-devel@nongnu.org; Mon, 29 Jul 2013 17:20:26 -0400
Received: from mx1.redhat.com ([209.132.183.28]:49317)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1V3ure-0007FD-Ec
	for qemu-devel@nongnu.org; Mon, 29 Jul 2013 17:20:22 -0400
Date: Mon, 29 Jul 2013 17:20:18 -0400
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20130729172018.302018df@redhat.com>
In-Reply-To: <51EDA2D1.5080603@suse.de>
References: <51ED9E3F.3080504@hds.com>
 <51EDA2D1.5080603@suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] Convert stderr message calling
 error_get_pretty() to error_report() to prepend timestamp
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andreas =?UTF-8?B?RsOkcmJlcg==?= <afaerber@suse.de>
Cc: Seiji Aguchi <seiji.aguchi@hds.com>, lersek@redhat.com, qemu-devel@nongnu.org, tomoki.sekiyama@hds.com

On Mon, 22 Jul 2013 23:23:29 +0200
Andreas F=C3=A4rber <afaerber@suse.de> wrote:

> Am 22.07.2013 23:03, schrieb Seiji Aguchi:
> > Convert stderr messages calling error_get_pretty()
> > to error_report().
> >=20
> > Timestamp is prepended by -msg timstamp option with it.
> >=20
> > This is suggested by Luiz Capitulino.
> >=20
> > http://marc.info/?l=3Dqemu-devel&m=3D137331442628866&w=3D2
> >=20
> > Signed-off-by: Seiji Aguchi <seiji.aguchi@hds.com>
> > ---
> >  arch_init.c                 |    4 ++--
> >  hw/char/serial.c            |    5 +++--
> >  hw/i386/pc.c                |    6 +++---
> >  qemu-char.c                 |    2 +-
> >  target-i386/cpu.c           |    2 +-
> >  target-ppc/translate_init.c |    3 ++-
> >  vl.c                        |    9 +++++----
> >  7 files changed, 17 insertions(+), 14 deletions(-)
>=20
> How is this related to error_get_pretty()?

Yeah, we're converting fprintf(stderr,) calls to error_report() so that
error messages get a timestamp.

> And does error_report() expect a trailing \n or not? I would assume no,
> but spotted some in this patch.

Yes, already confirmed by Markus.