From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58377) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V4A6L-0001d5-Dj for qemu-devel@nongnu.org; Tue, 30 Jul 2013 09:36:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V4A6F-0005zI-Dc for qemu-devel@nongnu.org; Tue, 30 Jul 2013 09:36:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:4943) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V4A6F-0005z4-5A for qemu-devel@nongnu.org; Tue, 30 Jul 2013 09:36:27 -0400 Date: Tue, 30 Jul 2013 09:31:13 -0400 From: Luiz Capitulino Message-ID: <20130730093113.43352e1b@redhat.com> In-Reply-To: <1375141192-1121-1-git-send-email-p.pawit@gmail.com> References: <1375141192-1121-1-git-send-email-p.pawit@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] migration: don't use uninitialized variables List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pawit Pornkitprasan Cc: Ryousei Takano , qemu-devel@nongnu.org, Juan Quintela On Tue, 30 Jul 2013 08:39:52 +0900 Pawit Pornkitprasan wrote: > The qmp_migrate method uses the 'blk' and 'inc' parameter without > checking if they're valid or not (they may be uninitialized if > command is received via QMP) > > Signed-off-by: Pawit Pornkitprasan Applied to the qmp branch, thanks. > --- > migration.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/migration.c b/migration.c > index 9fc7294..57a7998 100644 > --- a/migration.c > +++ b/migration.c > @@ -399,8 +399,8 @@ void qmp_migrate(const char *uri, bool has_blk, bool blk, > MigrationParams params; > const char *p; > > - params.blk = blk; > - params.shared = inc; > + params.blk = has_blk && blk; > + params.shared = has_inc && inc; > > if (s->state == MIG_STATE_ACTIVE || s->state == MIG_STATE_SETUP) { > error_set(errp, QERR_MIGRATION_ACTIVE);