From: Stefan Hajnoczi <stefanha@gmail.com>
To: MORITA Kazutaka <morita.kazutaka@lab.ntt.co.jp>
Cc: Kevin Wolf <kwolf@redhat.com>,
sheepdog@lists.wpkg.org, qemu-devel@nongnu.org,
Stefan Hajnoczi <stefanha@redhat.com>,
Liu Yuan <namei.unix@gmail.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v4 01/10] ignore SIGPIPE in qemu-img and qemu-io
Date: Tue, 30 Jul 2013 15:41:16 +0200 [thread overview]
Message-ID: <20130730134116.GA7471@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1374819052-4292-2-git-send-email-morita.kazutaka@lab.ntt.co.jp>
On Fri, Jul 26, 2013 at 03:10:43PM +0900, MORITA Kazutaka wrote:
> This prevents the tools from being stopped when they write data to a
> closed connection in the other side.
>
> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: MORITA Kazutaka <morita.kazutaka@lab.ntt.co.jp>
> ---
> qemu-img.c | 4 ++++
> qemu-io.c | 4 ++++
> 2 files changed, 8 insertions(+)
>
> diff --git a/qemu-img.c b/qemu-img.c
> index c55ca5c..919d464 100644
> --- a/qemu-img.c
> +++ b/qemu-img.c
> @@ -2319,6 +2319,10 @@ int main(int argc, char **argv)
> const img_cmd_t *cmd;
> const char *cmdname;
>
> +#ifdef CONFIG_POSIX
> + signal(SIGPIPE, SIG_IGN);
> +#endif
Reusing os_setup_early_signal_handling() would be messy, this seems fine
for now.
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
next prev parent reply other threads:[~2013-07-30 13:41 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-26 6:10 [Qemu-devel] [PATCH v4 00/10] sheepdog: reconnect server after connection failure MORITA Kazutaka
2013-07-26 6:10 ` [Qemu-devel] [PATCH v4 01/10] ignore SIGPIPE in qemu-img and qemu-io MORITA Kazutaka
2013-07-30 13:41 ` Stefan Hajnoczi [this message]
2013-07-26 6:10 ` [Qemu-devel] [PATCH v4 02/10] iov: handle EOF in iov_send_recv MORITA Kazutaka
2013-07-26 6:10 ` [Qemu-devel] [PATCH v4 03/10] sheepdog: check return values of qemu_co_recv/send correctly MORITA Kazutaka
2013-07-30 13:48 ` Stefan Hajnoczi
2013-08-02 6:09 ` [Qemu-devel] [sheepdog] " MORITA Kazutaka
2013-07-26 6:10 ` [Qemu-devel] [PATCH v4 04/10] sheepdog: handle vdi objects in resend_aio_req MORITA Kazutaka
2013-07-26 6:10 ` [Qemu-devel] [PATCH v4 05/10] sheepdog: reload inode outside of resend_aioreq MORITA Kazutaka
2013-07-26 6:10 ` [Qemu-devel] [PATCH v4 06/10] coroutine: add co_aio_sleep_ns() to allow sleep in block drivers MORITA Kazutaka
2013-07-30 13:58 ` Stefan Hajnoczi
2013-08-02 6:20 ` [Qemu-devel] [sheepdog] " MORITA Kazutaka
2013-08-02 8:19 ` liu ping fan
2013-08-02 9:35 ` Alex Bligh
2013-07-26 6:10 ` [Qemu-devel] [PATCH v4 07/10] sheepdog: try to reconnect to sheepdog after network error MORITA Kazutaka
2013-07-26 6:10 ` [Qemu-devel] [PATCH v4 08/10] sheepdog: make add_aio_request and send_aioreq void functions MORITA Kazutaka
2013-07-26 6:10 ` [Qemu-devel] [PATCH v4 09/10] sheepdog: cancel aio requests if possible MORITA Kazutaka
2013-07-26 6:10 ` [Qemu-devel] [PATCH v4 10/10] sheepdog: check simultaneous create in resend_aioreq MORITA Kazutaka
2013-07-30 14:13 ` [Qemu-devel] [PATCH v4 00/10] sheepdog: reconnect server after connection failure Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130730134116.GA7471@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=kwolf@redhat.com \
--cc=morita.kazutaka@lab.ntt.co.jp \
--cc=namei.unix@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sheepdog@lists.wpkg.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).