qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Michael Roth <mdroth@linux.vnet.ibm.com>
To: Tomoki Sekiyama <tomoki.sekiyama@hds.com>, qemu-devel@nongnu.org
Cc: libaiqing@huawei.com, ghammer@redhat.com, stefanha@gmail.com,
	lcapitulino@redhat.com, vrozenfe@redhat.com,
	Paolo Bonzini <pbonzini@redhat.com>,
	seiji.aguchi@hds.com, Laszlo Ersek <lersek@redhat.com>,
	areis@redhat.com
Subject: Re: [Qemu-devel] [PATCH v8 10/10] QMP/qemu-ga-client: Make timeout longer for guest-fsfreeze-freeze command
Date: Tue, 30 Jul 2013 15:21:56 -0500	[thread overview]
Message-ID: <20130730202156.14585.88249@loki> (raw)
In-Reply-To: <20130723224606.26273.97063.stgit@outback>

Quoting Tomoki Sekiyama (2013-07-23 17:46:06)
> guest-fsfreeze-freeze command can take longer than 3 seconds when heavy
> disk I/O is running. To avoid unexpected timeout, this changes the timeout
> to 60 seconds (timeout of pre-commit phase of VSS).
> 
> Signed-off-by: Tomoki Sekiyama <tomoki.sekiyama@hds.com>
> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Reviewed-by: Michael Roth <mdroth@linux.vnet.ibm.com>

> ---
>  QMP/qemu-ga-client |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/QMP/qemu-ga-client b/QMP/qemu-ga-client
> index 46676c3..b5f7e7c 100755
> --- a/QMP/qemu-ga-client
> +++ b/QMP/qemu-ga-client
> @@ -267,7 +267,9 @@ def main(address, cmd, args):
>              print('Hint: qemu is not running?')
>          sys.exit(1)
> 
> -    if cmd != 'ping':
> +    if cmd == 'fsfreeze' and args[0] == 'freeze':
> +        client.sync(60)
> +    elif cmd != 'ping':
>          client.sync()
> 
>      globals()['_cmd_' + cmd](client, args)

      reply	other threads:[~2013-07-30 20:48 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-23 22:45 [Qemu-devel] [PATCH v8 00/10] qemu-ga: fsfreeze on Windows using VSS Tomoki Sekiyama
2013-07-23 22:45 ` [Qemu-devel] [PATCH v8 01/10] configure: Support configuring C++ compiler Tomoki Sekiyama
2013-07-25 23:07   ` Michael Roth
2013-07-23 22:45 ` [Qemu-devel] [PATCH v8 02/10] Add c++ keywords to QAPI helper script Tomoki Sekiyama
2013-07-23 22:45 ` [Qemu-devel] [PATCH v8 03/10] checkpatch.pl: Check .cpp files Tomoki Sekiyama
2013-07-25 23:16   ` Michael Roth
2013-07-23 22:45 ` [Qemu-devel] [PATCH v8 04/10] Add a script to extract VSS SDK headers on POSIX system Tomoki Sekiyama
2013-07-23 22:45 ` [Qemu-devel] [PATCH v8 05/10] qemu-ga: Add configure options to specify path to Windows/VSS SDK Tomoki Sekiyama
2013-07-23 22:45 ` [Qemu-devel] [PATCH v8 06/10] error: Add error_set_win32 and error_setg_win32 Tomoki Sekiyama
2013-07-23 22:45 ` [Qemu-devel] [PATCH v8 07/10] qemu-ga: Add Windows VSS provider and requester as DLL Tomoki Sekiyama
2013-07-25 23:36   ` Michael Roth
2013-07-27  1:22   ` Michael Roth
2013-07-29 18:32     ` Tomoki Sekiyama
2013-07-30 19:35       ` Michael Roth
2013-07-30 20:54         ` Tomoki Sekiyama
2013-07-30 22:24           ` Michael Roth
2013-07-30 22:28             ` Tomoki Sekiyama
2013-07-23 22:45 ` [Qemu-devel] [PATCH v8 08/10] qemu-ga: Call Windows VSS requester in fsfreeze command handler Tomoki Sekiyama
2013-07-30 20:17   ` Michael Roth
2013-07-23 22:46 ` [Qemu-devel] [PATCH v8 09/10] qemu-ga: Install Windows VSS provider on `qemu-ga -s install' Tomoki Sekiyama
2013-07-30 20:20   ` Michael Roth
2013-07-23 22:46 ` [Qemu-devel] [PATCH v8 10/10] QMP/qemu-ga-client: Make timeout longer for guest-fsfreeze-freeze command Tomoki Sekiyama
2013-07-30 20:21   ` Michael Roth [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130730202156.14585.88249@loki \
    --to=mdroth@linux.vnet.ibm.com \
    --cc=areis@redhat.com \
    --cc=ghammer@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=lersek@redhat.com \
    --cc=libaiqing@huawei.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=seiji.aguchi@hds.com \
    --cc=stefanha@gmail.com \
    --cc=tomoki.sekiyama@hds.com \
    --cc=vrozenfe@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).