From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46221)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <flukshun@gmail.com>) id 1V4GqH-0008O5-Uo
	for qemu-devel@nongnu.org; Tue, 30 Jul 2013 16:48:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <flukshun@gmail.com>) id 1V4GqC-00019Q-QH
	for qemu-devel@nongnu.org; Tue, 30 Jul 2013 16:48:25 -0400
Received: from mail-ob0-x22a.google.com ([2607:f8b0:4003:c01::22a]:64223)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <flukshun@gmail.com>) id 1V4GQj-0008FB-1z
	for qemu-devel@nongnu.org; Tue, 30 Jul 2013 16:22:01 -0400
Received: by mail-ob0-f170.google.com with SMTP id eh20so1227950obb.15
	for <qemu-devel@nongnu.org>; Tue, 30 Jul 2013 13:22:00 -0700 (PDT)
Sender: fluxion <flukshun@gmail.com>
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
From: Michael Roth <mdroth@linux.vnet.ibm.com>
In-Reply-To: <20130723224606.26273.97063.stgit@outback>
References: <20130723224525.26273.28321.stgit@outback>
	<20130723224606.26273.97063.stgit@outback>
Message-ID: <20130730202156.14585.88249@loki>
Date: Tue, 30 Jul 2013 15:21:56 -0500
Subject: Re: [Qemu-devel] [PATCH v8 10/10] QMP/qemu-ga-client: Make timeout
 longer for guest-fsfreeze-freeze command
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Tomoki Sekiyama <tomoki.sekiyama@hds.com>, qemu-devel@nongnu.org
Cc: libaiqing@huawei.com, ghammer@redhat.com, stefanha@gmail.com, lcapitulino@redhat.com, vrozenfe@redhat.com, Paolo Bonzini <pbonzini@redhat.com>, seiji.aguchi@hds.com, Laszlo Ersek <lersek@redhat.com>, areis@redhat.com

Quoting Tomoki Sekiyama (2013-07-23 17:46:06)
> guest-fsfreeze-freeze command can take longer than 3 seconds when heavy
> disk I/O is running. To avoid unexpected timeout, this changes the timeout
> to 60 seconds (timeout of pre-commit phase of VSS).
> =

> Signed-off-by: Tomoki Sekiyama <tomoki.sekiyama@hds.com>
> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Reviewed-by: Michael Roth <mdroth@linux.vnet.ibm.com>

> ---
>  QMP/qemu-ga-client |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> =

> diff --git a/QMP/qemu-ga-client b/QMP/qemu-ga-client
> index 46676c3..b5f7e7c 100755
> --- a/QMP/qemu-ga-client
> +++ b/QMP/qemu-ga-client
> @@ -267,7 +267,9 @@ def main(address, cmd, args):
>              print('Hint: qemu is not running?')
>          sys.exit(1)
> =

> -    if cmd !=3D 'ping':
> +    if cmd =3D=3D 'fsfreeze' and args[0] =3D=3D 'freeze':
> +        client.sync(60)
> +    elif cmd !=3D 'ping':
>          client.sync()
> =

>      globals()['_cmd_' + cmd](client, args)