From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58570) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V4RTi-0006Br-G9 for qemu-devel@nongnu.org; Wed, 31 Jul 2013 04:09:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V4RTc-0002DZ-HW for qemu-devel@nongnu.org; Wed, 31 Jul 2013 04:09:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:25352) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V4RTc-0002DO-9h for qemu-devel@nongnu.org; Wed, 31 Jul 2013 04:09:44 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r6V89hmA000350 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 31 Jul 2013 04:09:43 -0400 Date: Wed, 31 Jul 2013 10:09:41 +0200 From: Kevin Wolf Message-ID: <20130731080941.GC3090@dhcp-200-207.str.redhat.com> References: <1374584606-5615-1-git-send-email-kwolf@redhat.com> <1374584606-5615-19-git-send-email-kwolf@redhat.com> <51F2B5AD.9050800@redhat.com> <20130726181406.GG18446@dhcp-200-207.str.redhat.com> <20130730134423.63800a98@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130730134423.63800a98@redhat.com> Subject: Re: [Qemu-devel] [PATCH 18/18] blockdev: 'blockdev-add' QMP command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: qemu-devel@nongnu.org, stefanha@redhat.com, armbru@redhat.com Am 30.07.2013 um 19:44 hat Luiz Capitulino geschrieben: > On Fri, 26 Jul 2013 20:14:06 +0200 > Kevin Wolf wrote: > > > Am 26.07.2013 um 19:45 hat Eric Blake geschrieben: > > > Overall, I like where this is headed, but I'm not quite sure it is ready > > > for commit as-is; looking forward to v2. Given my positive review on > > > the rest of the series, I think you could get away with a pull request > > > on the front half of the series and only respinning this patch, instead > > > of needing (re-)review of the entire series. > > > > Yup, that's exactly what I'm going to do now. I had considered merging > > the whole series, but I think you're right that committing it now might > > be a bit early. My main concern were potential conflicts in the front > > "half" (17/18) of the series when I'd wait too long with committing. > > Just to double check I got it as I'm still catching up with email > after vacation: you did exactly what was suggested by Eric, you > merged 1-17 and will post the blockdev-add command for 1.7? Correct. Patches 1-17 are in master now, and blockdev-add itself will be reposted during the 1.7 cycle. Kevin