From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40581) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V4USM-0002YQ-CJ for qemu-devel@nongnu.org; Wed, 31 Jul 2013 07:20:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V4USG-0000wX-6Y for qemu-devel@nongnu.org; Wed, 31 Jul 2013 07:20:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47003) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V4USF-0000wP-UW for qemu-devel@nongnu.org; Wed, 31 Jul 2013 07:20:32 -0400 Date: Wed, 31 Jul 2013 13:20:24 +0200 From: Stefan Hajnoczi Message-ID: <20130731112024.GD28592@stefanha-thinkpad.muc.redhat.com> References: <1375258430-2120-1-git-send-email-v.maffione@gmail.com> <51F8DF58.4030104@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH v5 0/2] e1000: add interrupt mitigation support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vincenzo Maffione Cc: Anthony Liguori , "Michael S. Tsirkin" , Luigi Rizzo , Jason Wang , qemu-devel@nongnu.org, Paolo Bonzini , Giuseppe Lettieri , lersek@redhat.com, Andreas =?iso-8859-1?Q?F=E4rber?= On Wed, Jul 31, 2013 at 12:19:06PM +0200, Vincenzo Maffione wrote: > Sorry, I'm not confident with this infrastructure. Thanks for your efforts! Normally this change would not be necessary but you are the first person who needs a 1.6 compat property :). > So do you just want me to invert the commit order? (and do the other > two little changes) Yes, please introduce an empty PC_COMPAT_1_6 in Patch 1 and then make use of it for e1000 interrupt mitigation in Patch 2. That way creating PC_COMPAT_1_6 is an independent commit which can be cherry-picked and reused independently of e1000 interrupt mitigation. Stefan