From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38933) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V4pwO-0001SN-Pe for qemu-devel@nongnu.org; Thu, 01 Aug 2013 06:17:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V4pwG-0006wI-6c for qemu-devel@nongnu.org; Thu, 01 Aug 2013 06:17:04 -0400 Date: Thu, 1 Aug 2013 11:42:49 +0200 From: Stefan Hajnoczi Message-ID: <20130801094249.GD29838@stefanha-thinkpad.redhat.com> References: <1375305626-26972-1-git-send-email-rjones@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1375305626-26972-1-git-send-email-rjones@redhat.com> Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH v3] block/iscsi.c: Fix printf format error. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Richard W.M. Jones" Cc: qemu-trivial@nongnu.org, sw@weilnetz.de, qemu-devel@nongnu.org, afaerber@suse.de On Wed, Jul 31, 2013 at 10:20:26PM +0100, Richard W.M. Jones wrote: > From: "Richard W.M. Jones" > > The error on armv7hl was: > > block/iscsi.c: In function ‘is_request_lun_aligned’: > block/iscsi.c:251:26: error: format ‘%ld’ expects argument of type ‘long int’, but argument 3 has type ‘int64_t’ [-Werror=format=] > iscsilun->block_size, sector_num, nb_sectors); > ^ > > This also splits the long line to comply with qemu coding guidelines. > > Signed-off-by: Richard W.M. Jones > --- > block/iscsi.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Reviewed-by: Stefan Hajnoczi