From: Stefan Hajnoczi <stefanha@redhat.com>
To: Jeff Cody <jcody@redhat.com>
Cc: kwolf@redhat.com, famz@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 6/9] block: vhdx - update log guid in header, and first write tracker
Date: Thu, 1 Aug 2013 17:09:44 +0200 [thread overview]
Message-ID: <20130801150944.GG2387@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <a1228129c5be1851c269658d8b40db632fa198a1.1375325971.git.jcody@redhat.com>
On Wed, Jul 31, 2013 at 11:23:51PM -0400, Jeff Cody wrote:
> @@ -998,6 +1006,16 @@ exit:
>
>
>
> +/* Per the spec, on the first write of guest-visible data to the file the
> + * data write guid must be updated in the header */
> +void vhdx_user_visible_write(BlockDriverState *bs, BDRVVHDXState *s)
> +{
> + if (s->first_visible_write) {
> + s->first_visible_write = false;
> + vhdx_update_headers(bs, s, true, NULL);
Error handling is missing.
next prev parent reply other threads:[~2013-08-01 15:09 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-01 3:23 [Qemu-devel] [PATCH v2 0/9] VHDX log replay and write support Jeff Cody
2013-08-01 3:23 ` [Qemu-devel] [PATCH v2 1/9] block: vhdx - minor comments and typo correction Jeff Cody
2013-08-01 3:23 ` [Qemu-devel] [PATCH v2 2/9] block: vhdx - add header update capability Jeff Cody
2013-08-01 13:44 ` Stefan Hajnoczi
2013-08-01 14:09 ` Jeff Cody
2013-08-07 14:42 ` Jeff Cody
2013-08-05 11:42 ` Kevin Wolf
2013-08-05 14:43 ` Jeff Cody
2013-08-05 14:45 ` Kevin Wolf
2013-08-05 14:57 ` Jeff Cody
2013-08-05 15:05 ` Kevin Wolf
2013-08-05 15:09 ` Jeff Cody
2013-08-06 8:34 ` Kevin Wolf
2013-08-01 3:23 ` [Qemu-devel] [PATCH v2 3/9] block: vhdx code movement - VHDXMetadataEntries and BDRVVHDXState to header Jeff Cody
2013-08-01 3:23 ` [Qemu-devel] [PATCH v2 4/9] block: vhdx - log support struct and defines Jeff Cody
2013-08-01 15:00 ` Stefan Hajnoczi
2013-08-01 15:51 ` Jeff Cody
2013-08-07 15:22 ` Kevin Wolf
2013-08-07 17:18 ` Jeff Cody
2013-08-01 3:23 ` [Qemu-devel] [PATCH v2 5/9] block: vhdx - break endian translation functions out Jeff Cody
2013-08-01 15:03 ` Stefan Hajnoczi
2013-08-01 15:14 ` Jeff Cody
2013-08-07 15:29 ` Kevin Wolf
2013-08-07 17:21 ` Jeff Cody
2013-08-01 3:23 ` [Qemu-devel] [PATCH v2 6/9] block: vhdx - update log guid in header, and first write tracker Jeff Cody
2013-08-01 15:09 ` Stefan Hajnoczi [this message]
2013-08-01 3:23 ` [Qemu-devel] [PATCH v2 7/9] block: vhdx - log parsing, replay, and flush support Jeff Cody
2013-08-01 3:23 ` [Qemu-devel] [PATCH v2 8/9] block: vhdx - add log write support Jeff Cody
2013-08-01 3:23 ` [Qemu-devel] [PATCH v2 9/9] block: vhdx " Jeff Cody
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130801150944.GG2387@stefanha-thinkpad.redhat.com \
--to=stefanha@redhat.com \
--cc=famz@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).