From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39607)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1V5LLg-0005lK-4q
	for qemu-devel@nongnu.org; Fri, 02 Aug 2013 15:49:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1V5LLb-0007A0-55
	for qemu-devel@nongnu.org; Fri, 02 Aug 2013 15:49:16 -0400
Received: from mx1.redhat.com ([209.132.183.28]:48863)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1V5GaO-00075w-6x
	for qemu-devel@nongnu.org; Fri, 02 Aug 2013 10:44:08 -0400
Date: Fri, 2 Aug 2013 16:43:54 +0200
From: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20130802144354.GG815@stefanha-thinkpad.redhat.com>
References: <CAJnKYQns35_vyr=kyGNEF4__paK1s==38Uc9U+2gvZMKyBbYQw@mail.gmail.com>
	<51F65044.4040706@redhat.com>
	<CAJnKYQmznzjHUFRb_BbDN+3p9KtaS0G6c_RNrgPFetRpk6431w@mail.gmail.com>
	<51F78491.708@redhat.com>
	<CAJnKYQmL0UnOM=OpfUGiEsZZvs-2EA2B9PutNJONW3osCkFn3w@mail.gmail.com>
	<391717867.8023244.1375347472193.JavaMail.root@redhat.com>
	<753B6C66578E71C12F9DFD2A@Ximines.local>
	<1277844563.8104892.1375359574399.JavaMail.root@redhat.com>
	<97E9EFDF2EC4B9CE77638619@Ximines.local>
	<CAJnKYQmx1UDM8R2VpyvPLKJbWG7+LwUWe+Y6oNazHhesQobMHA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAJnKYQmx1UDM8R2VpyvPLKJbWG7+LwUWe+Y6oNazHhesQobMHA@mail.gmail.com>
Subject: Re: [Qemu-devel] [RFC v2 3/5] timer: make qemu_clock_enable sync
 between disable and timer's cb
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: liu ping fan <qemulist@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Alex Bligh <alex@alex.org.uk>, Jan Kiszka <jan.kiszka@siemens.com>, qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>, Paolo Bonzini <pbonzini@redhat.com>

On Fri, Aug 02, 2013 at 11:33:40AM +0800, liu ping fan wrote:
> On Thu, Aug 1, 2013 at 9:28 PM, Alex Bligh <alex@alex.org.uk> wrote:
> > Paolo,
> >
> >
> > --On 1 August 2013 08:19:34 -0400 Paolo Bonzini <pbonzini@redhat.com> wrote:
> >
> >>> > True, qemu_event basically works only when a single thread resets it.
> >>> > But there is no race condition here because qemu_run_timers cannot be
> >>> > executed concurrently by multiple threads (like aio_poll in your
> >>> > bottom half patches).
> >>>
> >>> ... or, if rebasing on top of my patches, qemu_run_timers *can* be
> >>> executed concurrently by mulitple threads, but in respect of any given
> >>> QEMUTimerList, it will only be executed by one thread.
> >>
> >>
> >> ... so the event would be placed in QEMUTimerList, not QEMUClock.
> >
> >
> > Correct
> >
> >
> >> qemu_clock_enable then will have to visit all timer lists. That's
> >> not hard to do,
> >
> >
> > Correct, v4 of my patch does this.
> >
> >
> >> but as locks proliferate we need to have a clear
> >> policy (e.g. BQL -> clock -> timerlist).
> >
> >
> > But doesn't do the locking bit yet (Pingfan is going to do that I hope)
> >
> Seem that Stefanha had been involved in this, and sent out his patches :)

Hi Ping Fan,
I dropped the series where I added locks to qemu-timer.c from a few
weeks ago.

With your series rebased onto Alex's series, I think my patches are no
longer needed?

Stefan