From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54374)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1V5Mqb-0000lQ-U1
	for qemu-devel@nongnu.org; Fri, 02 Aug 2013 17:25:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1V5Gvn-0007UM-JT
	for qemu-devel@nongnu.org; Fri, 02 Aug 2013 11:06:22 -0400
Received: from mx1.redhat.com ([209.132.183.28]:20096)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1V5Gvn-0007U6-AR
	for qemu-devel@nongnu.org; Fri, 02 Aug 2013 11:06:15 -0400
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
	(int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r72F6EXY019514
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Fri, 2 Aug 2013 11:06:14 -0400
Date: Fri, 2 Aug 2013 17:06:13 +0200
From: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20130802150613.GI815@stefanha-thinkpad.redhat.com>
References: <1375265640-27307-1-git-send-email-famz@redhat.com>
	<20130801122821.GC2387@stefanha-thinkpad.redhat.com>
	<20130802022213.GA2864@T430s.nay.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20130802022213.GA2864@T430s.nay.redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 0/7] Implement reference count for
	BlockDriverState
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: kwolf@redhat.com, jcody@redhat.com, qemu-devel@nongnu.org

On Fri, Aug 02, 2013 at 10:22:13AM +0800, Fam Zheng wrote:
> On Thu, 08/01 14:28, Stefan Hajnoczi wrote:
> > On Wed, Jul 31, 2013 at 06:13:53PM +0800, Fam Zheng wrote:
> > Follow-up question:
> > 
> > Did you look at using bdrv_ref() for the BDS <- BlockJob relationship
> > too?
> > 
> > blockdev.c block job code still uses the DriveInfo refcount after your
> > series.  The BDS reference would be sufficient since the DriveInfo
> > fields are not used by block jobs.
> > 
> For now they coexist, which works but with redundancy. I will send
> follow-up patch(es) to clean up block job to only use BDS refcount.

Wenchao's review comment pointed out the case where block job
termination will segfault if DriveInfo has been deleted.  I think this
needs to be address together with these patches instead of later.

Stefan