From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55395) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V5jtQ-0005bK-Od for qemu-devel@nongnu.org; Sat, 03 Aug 2013 18:01:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V5jtP-0004be-P8 for qemu-devel@nongnu.org; Sat, 03 Aug 2013 18:01:44 -0400 Received: from hall.aurel32.net ([2001:470:1f0b:4a8::1]:56019) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V5jtP-0004ZZ-IH for qemu-devel@nongnu.org; Sat, 03 Aug 2013 18:01:43 -0400 Date: Sun, 4 Aug 2013 00:01:32 +0200 From: Aurelien Jarno Message-ID: <20130803220132.GA20566@ohm.aurel32.net> References: <1375351347-16604-1-git-send-email-leon.alrae@imgtec.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1375351347-16604-1-git-send-email-leon.alrae@imgtec.com> Subject: Re: [Qemu-devel] [PATCH] target-mips: fix decoding of microMIPS POOL32Axf instructions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Leon Alrae Cc: yongbok.kim@imgtec.com, cristian.cuna@imgtec.com, qemu-devel@nongnu.org On Thu, Aug 01, 2013 at 11:02:27AM +0100, Leon Alrae wrote: > These are not DSP instructions, thus there is no "ac" field. > > For more details please refer to instruction encoding of > MULT, MULTU, MADD, MADDU, MSUB, MSUBU, MFHI, MFLO, MTHI, MTLO in > MIPS Architecture for Programmers Volume II-B: The microMIPS32 Instruction Set These instructions have both a non DSP version without the "ac" field, and a DSP version with the "ac" field. The encoding of the "ac" field is done in bits 14 and 15, so the current QEMU code is correct. Please refer to the MIPS32® Architecture Manual Volume IV-e: The MIPS® DSP Application-Specific Extension to the microMIPS32® Architecture (document MD00764). -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net