From: Kevin Wolf <kwolf@redhat.com>
To: Doug Goldstein <cardoe@gentoo.org>
Cc: Stefan Hajnoczi <stefanha@redhat.com>,
sheepdog@lists.wpkg.org, qemu-devel <qemu-devel@nongnu.org>,
MORITA Kazutaka <morita.kazutaka@lab.ntt.co.jp>,
qemu-stable@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 02/11] iov: handle EOF in iov_send_recv
Date: Mon, 5 Aug 2013 14:30:14 +0200 [thread overview]
Message-ID: <20130805123014.GH2654@dhcp-200-207.str.redhat.com> (raw)
In-Reply-To: <CAFWqQMSLHZy0ozMHcqnkPtOq4NS=7fDnH9YUONR5p+56J4C+pQ@mail.gmail.com>
Am 03.08.2013 um 05:48 hat Doug Goldstein geschrieben:
> On Tue, Jul 23, 2013 at 6:28 AM, Paolo Bonzini <pbonzini@redhat.com> wrote:
> > Il 23/07/2013 10:30, MORITA Kazutaka ha scritto:
> >> Without this patch, iov_send_recv() never returns when do_send_recv()
> >> returns zero.
> >>
> >> Signed-off-by: MORITA Kazutaka <morita.kazutaka@lab.ntt.co.jp>
> >> ---
> >> util/iov.c | 6 ++++++
> >> 1 file changed, 6 insertions(+)
> >>
> >> diff --git a/util/iov.c b/util/iov.c
> >> index cc6e837..f705586 100644
> >> --- a/util/iov.c
> >> +++ b/util/iov.c
> >> @@ -202,6 +202,12 @@ ssize_t iov_send_recv(int sockfd, struct iovec *iov, unsigned iov_cnt,
> >> return -1;
> >> }
> >>
> >> + if (ret == 0 && !do_send) {
> >> + /* recv returns 0 when the peer has performed an orderly
> >> + * shutdown. */
> >> + break;
> >> + }
> >> +
> >> /* Prepare for the next iteration */
> >> offset += ret;
> >> total += ret;
> >>
> >
> > Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
> >
> > ... and should also be in 1.5.2.
> >
> > Paolo
> >
>
> Nudge so this doesn't get forgotten about. It hasn't hit master yet.
Thanks, applied to the block branch.
Kevin
next prev parent reply other threads:[~2013-08-05 12:30 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-23 8:30 [Qemu-devel] [PATCH 00/11] sheepdog: reconnect server after connection failure MORITA Kazutaka
2013-07-23 8:30 ` [Qemu-devel] [PATCH 01/11] ignore SIGPIPE in qemu-img and qemu-io MORITA Kazutaka
2013-07-23 9:19 ` [Qemu-devel] [PATCH for-1.6 " Paolo Bonzini
2013-08-03 3:52 ` Doug Goldstein
2013-08-05 11:57 ` Kevin Wolf
2013-07-23 8:30 ` [Qemu-devel] [PATCH 02/11] iov: handle EOF in iov_send_recv MORITA Kazutaka
2013-07-23 11:28 ` Paolo Bonzini
2013-08-03 3:48 ` Doug Goldstein
2013-08-05 12:30 ` Kevin Wolf [this message]
2013-07-23 8:30 ` [Qemu-devel] [PATCH 03/11] qemu-sockets: make wait_for_connect be invoked in qemu_aio_wait MORITA Kazutaka
2013-07-23 11:36 ` Paolo Bonzini
2013-07-24 7:41 ` [Qemu-devel] [sheepdog] " MORITA Kazutaka
2013-07-23 8:30 ` [Qemu-devel] [PATCH 04/11] sheepdog: make connect nonblocking MORITA Kazutaka
2013-07-23 8:30 ` [Qemu-devel] [PATCH 05/11] sheepdog: check return values of qemu_co_recv/send correctly MORITA Kazutaka
2013-07-23 8:30 ` [Qemu-devel] [PATCH 06/11] sheepdog: handle vdi objects in resend_aio_req MORITA Kazutaka
2013-07-23 8:30 ` [Qemu-devel] [PATCH 07/11] sheepdog: reload inode outside of resend_aioreq MORITA Kazutaka
2013-07-23 8:30 ` [Qemu-devel] [PATCH 08/11] coroutine: add co_aio_sleep_ns() to allow sleep in block drivers MORITA Kazutaka
2013-07-23 8:30 ` [Qemu-devel] [PATCH 09/11] sheepdog: try to reconnect to sheepdog after network error MORITA Kazutaka
2013-07-23 8:30 ` [Qemu-devel] [PATCH 10/11] sheepdog: make add_aio_request and send_aioreq void functions MORITA Kazutaka
2013-07-23 8:30 ` [Qemu-devel] [PATCH 11/11] sheepdog: cancel aio requests if possible MORITA Kazutaka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130805123014.GH2654@dhcp-200-207.str.redhat.com \
--to=kwolf@redhat.com \
--cc=cardoe@gentoo.org \
--cc=morita.kazutaka@lab.ntt.co.jp \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=sheepdog@lists.wpkg.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).